[Obs Overview] Replace clickable tooltip with external link#213741
Merged
baileycash-elastic merged 11 commits intoelastic:mainfrom Mar 17, 2025
Merged
[Obs Overview] Replace clickable tooltip with external link#213741baileycash-elastic merged 11 commits intoelastic:mainfrom
baileycash-elastic merged 11 commits intoelastic:mainfrom
Conversation
baileycash-elastic
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
reviewed
Mar 11, 2025
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
one comment but otherwise looks good to me
...ility/public/pages/overview/components/sections/ux/core_web_vitals/web_core_vitals_title.tsx
Outdated
Show resolved
Hide resolved
baileycash-elastic
force-pushed
the
slo-core-web-vitals-link
branch
from
b717d99 to
c0198dc
Compare
Contributor
Author
|
@elasticmachine merge upstream |
...ervability/plugins/observability/public/pages/overview/components/sections/ux/ux_section.tsx
Outdated
Show resolved
Hide resolved
kdelemme
approved these changes
Mar 12, 2025
Comment on lines
62
to
72
| <EuiLink | ||
| style={{ fontSize: 14 }} | ||
| data-test-subj="o11yWebCoreVitalsTitleLink" | ||
| href="https://web.dev/vitals/" | ||
| external | ||
| target="_blank" | ||
| > | ||
| {i18n.translate('xpack.observability.ux.dashboard.webCoreVitals.help', { | ||
| defaultMessage: 'Learn more', | ||
| })} | ||
| </EuiLink> |
Contributor
There was a problem hiding this comment.
Instead of manually changing the fontSize you could wrap EuiLink with EuiText
Suggested change
| <EuiLink | |
| style={{ fontSize: 14 }} | |
| data-test-subj="o11yWebCoreVitalsTitleLink" | |
| href="https://web.dev/vitals/" | |
| external | |
| target="_blank" | |
| > | |
| {i18n.translate('xpack.observability.ux.dashboard.webCoreVitals.help', { | |
| defaultMessage: 'Learn more', | |
| })} | |
| </EuiLink> | |
| <EuiText size="s"> | |
| <EuiLink | |
| data-test-subj="o11yWebCoreVitalsTitleLink" | |
| href="https://web.dev/vitals/" | |
| external | |
| target="_blank" | |
| > | |
| {i18n.translate('xpack.observability.ux.dashboard.webCoreVitals.help', { | |
| defaultMessage: 'Learn more', | |
| })} | |
| </EuiLink> | |
| </EuiText> |
| displayServiceName={true} | ||
| serviceName={serviceName} | ||
| /> | ||
| <div style={{ marginTop: 24 }}> |
Contributor
There was a problem hiding this comment.
Same here:
Suggested change
| <div style={{ marginTop: 24 }}> | |
| <EuiSpacer size="xl"> |
| <CoreVitals | ||
| data={coreWebVitals} | ||
| loading={isLoading} | ||
| displayServiceName={true} |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| displayServiceName={true} | |
| displayServiceName |
| <EuiLink | ||
| style={{ fontSize: 14 }} | ||
| data-test-subj="o11yWebCoreVitalsTitleLink" | ||
| href="https://web.dev/vitals/" |
Contributor
There was a problem hiding this comment.
nit: could we create a constant for this url?
Contributor
There was a problem hiding this comment.
And create a shorter version with Elastic links
Contributor
Author
There was a problem hiding this comment.
And create a shorter version with Elastic links
Will you share documentation?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Let me know if the updated urls are okay
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13902911830 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 17, 2025
…213741) ## Summary Resolves [this issue](elastic#210168) Vital links / clickable items should not be hidden behind tooltips that require an additional click, as they do not include necessary indicators for screen readers. Converting the clickable tooltip with the core web vitals docs to a standard link. <img width="1727" alt="Screenshot 2025-03-10 at 9 33 30 AM" src="https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 26d84c4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 17, 2025
…213741) ## Summary Resolves [this issue](elastic#210168) Vital links / clickable items should not be hidden behind tooltips that require an additional click, as they do not include necessary indicators for screen readers. Converting the clickable tooltip with the core web vitals docs to a standard link. <img width="1727" alt="Screenshot 2025-03-10 at 9 33 30 AM" src="https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 26d84c4)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Mar 17, 2025
kibanamachine
added a commit
that referenced
this pull request
Mar 17, 2025
…13741) (#214799) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs Overview] Replace clickable tooltip with external link (#213741)](#213741) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-03-17T15:09:13Z","message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-management","backport:current-major","obs-accessibilty","v9.1.0","v8.19.0"],"title":"[Obs Overview] Replace clickable tooltip with external link","number":213741,"url":"https://github.com/elastic/kibana/pull/213741","mergeCommit":{"message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213741","number":213741,"mergeCommit":{"message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 17, 2025
…13741) (#214800) # Backport This will backport the following commits from `main` to `9.0`: - [[Obs Overview] Replace clickable tooltip with external link (#213741)](#213741) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-03-17T15:09:13Z","message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-management","backport:current-major","obs-accessibilty","v9.1.0","v8.19.0"],"title":"[Obs Overview] Replace clickable tooltip with external link","number":213741,"url":"https://github.com/elastic/kibana/pull/213741","mergeCommit":{"message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213741","number":213741,"mergeCommit":{"message":"[Obs Overview] Replace clickable tooltip with external link (#213741)\n\n## Summary\n\nResolves [this issue](https://github.com/elastic/kibana/issues/210168)\n\nVital links / clickable items should not be hidden behind tooltips that\nrequire an additional click, as they do not include necessary indicators\nfor screen readers. Converting the clickable tooltip with the core web\nvitals docs to a standard link.\n\n<img width=\"1727\" alt=\"Screenshot 2025-03-10 at 9 33 30 AM\"\nsrc=\"https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"26d84c4e1375362ef3a494fb9c9961c17e3ea1f8"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
…213741) ## Summary Resolves [this issue](elastic#210168) Vital links / clickable items should not be hidden behind tooltips that require an additional click, as they do not include necessary indicators for screen readers. Converting the clickable tooltip with the core web vitals docs to a standard link. <img width="1727" alt="Screenshot 2025-03-10 at 9 33 30 AM" src="https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…213741) ## Summary Resolves [this issue](elastic#210168) Vital links / clickable items should not be hidden behind tooltips that require an additional click, as they do not include necessary indicators for screen readers. Converting the clickable tooltip with the core web vitals docs to a standard link. <img width="1727" alt="Screenshot 2025-03-10 at 9 33 30 AM" src="https://github.com/user-attachments/assets/ab611238-1fa1-455b-b0c4-563ae875e51d" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves this issue
Vital links / clickable items should not be hidden behind tooltips that require an additional click, as they do not include necessary indicators for screen readers. Converting the clickable tooltip with the core web vitals docs to a standard link.