Include additional fields for summary column#213687
Include additional fields for summary column#213687thomheymann merged 4 commits intoelastic:mainfrom
Conversation
…include-additional-fields-for-summary-column
...-contextual-components/src/data_types/logs/components/summary_column/summary_column.test.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
yngrdyn
left a comment
There was a problem hiding this comment.
LGTM, well tested and neat solution 🚀
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13833481430 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
@thomheymann this should just be backported to 8.19 right? |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
4 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Resolves elastic#196513 ## Summary Updates fields in Discover summary column. ## Logic remove ``` cloud.instance.id orchestrator.namespace ``` In addition we need to implement some logic to have a fallback, selecting the first field with a value in descending order: Add fallback mechanism to container.name ``` kubernetes.container.name => k8s.container.name => container.name ``` Add fallback mechanism to host.name ``` kubernetes.node.name => k8s.node.name => host.name ``` Add fallback mechanism to cluster.name ``` orchestrator.cluster.name => k8s.cluster.name ``` Add new fields with fallbacks ``` kubernetes.namespace => (k8s.namespace.name) kubernetes.pod.name => (k8s.pod.name) // only one of these will be present in a single doc: kubernetes.deployment.name => (k8s.deployment.name) kubernetes.replicaset.name => (k8s.replicaset.name) kubernetes.statefulset.name => (k8s.statefulset.name) kubernetes.daemonset.name => (k8s.daemonset.name) kubernetes.job.name => (k8s.job.name) kubernetes.cronjob.name => (k8s.cronjob.name) ```
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Resolves elastic#196513 ## Summary Updates fields in Discover summary column. ## Logic remove ``` cloud.instance.id orchestrator.namespace ``` In addition we need to implement some logic to have a fallback, selecting the first field with a value in descending order: Add fallback mechanism to container.name ``` kubernetes.container.name => k8s.container.name => container.name ``` Add fallback mechanism to host.name ``` kubernetes.node.name => k8s.node.name => host.name ``` Add fallback mechanism to cluster.name ``` orchestrator.cluster.name => k8s.cluster.name ``` Add new fields with fallbacks ``` kubernetes.namespace => (k8s.namespace.name) kubernetes.pod.name => (k8s.pod.name) // only one of these will be present in a single doc: kubernetes.deployment.name => (k8s.deployment.name) kubernetes.replicaset.name => (k8s.replicaset.name) kubernetes.statefulset.name => (k8s.statefulset.name) kubernetes.daemonset.name => (k8s.daemonset.name) kubernetes.job.name => (k8s.job.name) kubernetes.cronjob.name => (k8s.cronjob.name) ``` (cherry picked from commit 37c88f9) # Conflicts: # src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/constants.ts # src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/utils/get_available_resource_fields.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Resolves elastic#196513 ## Summary Updates fields in Discover summary column. ## Logic remove ``` cloud.instance.id orchestrator.namespace ``` In addition we need to implement some logic to have a fallback, selecting the first field with a value in descending order: Add fallback mechanism to container.name ``` kubernetes.container.name => k8s.container.name => container.name ``` Add fallback mechanism to host.name ``` kubernetes.node.name => k8s.node.name => host.name ``` Add fallback mechanism to cluster.name ``` orchestrator.cluster.name => k8s.cluster.name ``` Add new fields with fallbacks ``` kubernetes.namespace => (k8s.namespace.name) kubernetes.pod.name => (k8s.pod.name) // only one of these will be present in a single doc: kubernetes.deployment.name => (k8s.deployment.name) kubernetes.replicaset.name => (k8s.replicaset.name) kubernetes.statefulset.name => (k8s.statefulset.name) kubernetes.daemonset.name => (k8s.daemonset.name) kubernetes.job.name => (k8s.job.name) kubernetes.cronjob.name => (k8s.cronjob.name) ``` (cherry picked from commit 37c88f9) # Conflicts: # src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/constants.ts # src/platform/packages/shared/kbn-discover-utils/src/data_types/logs/utils/get_available_resource_fields.ts
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
4 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
@thomheymann shall we get the 9.0 backport closed and carry on with 8.x? |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
10 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Resolves #196513
Summary
Updates fields in Discover summary column.
Logic
remove
In addition we need to implement some logic to have a fallback, selecting the first field with a value in descending order:
Add fallback mechanism to container.name
Add fallback mechanism to host.name
Add fallback mechanism to cluster.name
Add new fields with fallbacks