Skip to content

[SLO] file reorg, improvements to badge#213597

Merged
baileycash-elastic merged 2 commits intoelastic:mainfrom
baileycash-elastic:4347-updates
Mar 10, 2025
Merged

[SLO] file reorg, improvements to badge#213597
baileycash-elastic merged 2 commits intoelastic:mainfrom
baileycash-elastic:4347-updates

Conversation

@baileycash-elastic
Copy link
Contributor

@baileycash-elastic baileycash-elastic commented Mar 7, 2025

Summary

Screenshot 2025-03-10 at 9 27 54 AM

This PR:

  • Removes unnecessary usage of useMemo for SLI badge value
  • Improves component organization
  • Improves SLI presentation

@baileycash-elastic baileycash-elastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.0.0 v9.1.0 labels Mar 7, 2025
@baileycash-elastic baileycash-elastic marked this pull request as ready for review March 7, 2025 16:22
@baileycash-elastic baileycash-elastic requested a review from a team as a code owner March 7, 2025 16:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@baileycash-elastic
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 noice

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 920.3KB 920.3KB -43.0B

History

@baileycash-elastic baileycash-elastic merged commit 311417d into elastic:main Mar 10, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13769017079

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 10, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

baileycash-elastic added a commit that referenced this pull request Mar 11, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[SLO] file reorg, improvements to badge
(#213597)](#213597)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T15:53:03Z","message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management","v9.1.0"],"title":"[SLO]
file reorg, improvements to
badge","number":213597,"url":"https://github.com/elastic/kibana/pull/213597","mergeCommit":{"message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213597","number":213597,"mergeCommit":{"message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095"}}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request May 7, 2025
@kdelemme
Copy link
Contributor

kdelemme commented May 7, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit that referenced this pull request May 7, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[SLO] file reorg, improvements to badge
(#213597)](#213597)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T15:53:03Z","message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management","v9.1.0"],"title":"[SLO]
file reorg, improvements to
badge","number":213597,"url":"https://github.com/elastic/kibana/pull/213597","mergeCommit":{"message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213777","number":213777,"state":"MERGED","mergeCommit":{"sha":"cb90918396ddc5265426131e0d8c090c511b0330","message":"[9.0]
[SLO] file reorg, improvements to badge (#213597) (#213777)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.0`:\n- [[SLO] file reorg, improvements to
badge\n(#213597)](https://github.com/elastic/kibana/pull/213597)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Bailey Cash
<bailey.cash@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213597","number":213597,"mergeCommit":{"message":"[SLO]
file reorg, improvements to badge
(#213597)","sha":"311417d78e4e379369a087f81c818e433d63e095"}}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants