Criticality badge medium impact bug / typo fixed#213456
Merged
CAWilson94 merged 2 commits intoelastic:mainfrom Mar 7, 2025
Merged
Criticality badge medium impact bug / typo fixed#213456CAWilson94 merged 2 commits intoelastic:mainfrom
CAWilson94 merged 2 commits intoelastic:mainfrom
Conversation
CAWilson94
added
bug
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
CAWilson94
added
backport:skip
jaredburgettelastic
approved these changes
Mar 6, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @CAWilson94 |
1 task
CAWilson94
added a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary This PR fixes the colour on medium impact showing on asset criticality badges across alerts table. ### Reproduce Bug 1. Kibana latest version 2. Generate entity store data 3. navigate to alerts page, with alerts generated 4. Look at host criticality and user criticality columns 5. Observe that, the badges for these columns are transparent. Hover over to see details. ### Screenshot: Bug  ### Testing Fix Same steps as above, but with this PR, observe that the badged for medium impact now have the relevent colouring enabled. ### Screenshots: Fix in Place Host Criticality, Dark Theme | User Criticality, Dark Theme :-------------------------:|:-------------------------: ! |  Host Criticality, Light Theme | User Criticality, Light Theme :-------------------------:|:-------------------------: ! | 
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the colour on medium impact showing on asset criticality badges across alerts table.
Reproduce Bug
Screenshot: Bug
Testing Fix
Same steps as above, but with this PR, observe that the badged for medium impact now have the relevent colouring enabled.
Screenshots: Fix in Place