Skip to content

[Siem Migrations] Add Translated Rules Empty Page#213438

Merged
logeekal merged 6 commits intoelastic:mainfrom
logeekal:feat/siem_migrations_translated_rule_empty
Mar 12, 2025
Merged

[Siem Migrations] Add Translated Rules Empty Page#213438
logeekal merged 6 commits intoelastic:mainfrom
logeekal:feat/siem_migrations_translated_rule_empty

Conversation

@logeekal
Copy link
Contributor

@logeekal logeekal commented Mar 6, 2025

Summary

This PR adds empty state for Translated Rules Page.

translated_rule_empty_placeholder.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@logeekal logeekal added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting Security Solution Threat Hunting Team backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Mar 6, 2025
@logeekal logeekal requested a review from a team as a code owner March 6, 2025 17:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯
Thanks @logeekal for taking the time to address the comments

@logeekal logeekal enabled auto-merge (squash) March 12, 2025 09:55
@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

@logeekal logeekal requested review from a team as code owners March 12, 2025 12:13
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Mar 12, 2025
@logeekal logeekal force-pushed the feat/siem_migrations_translated_rule_empty branch from e53ce14 to 0e4c0c3 Compare March 12, 2025 12:17
@logeekal logeekal removed request for a team March 12, 2025 12:17
@logeekal logeekal merged commit bbc91a2 into elastic:main Mar 12, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13813196997

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 12, 2025
## Summary

This PR adds empty state for Translated Rules Page.

https://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit bbc91a2)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 12, 2025
## Summary

This PR adds empty state for Translated Rules Page.

https://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit bbc91a2)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 12, 2025
## Summary

This PR adds empty state for Translated Rules Page.

https://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit bbc91a2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 12, 2025
…14170)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Siem Migrations] Add Translated Rules Empty Page
(#213438)](#213438)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T13:59:12Z","message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ExpressionLanguage","release_note:skip","v9.0.0","Team:Threat
Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Siem
Migrations] Add Translated Rules Empty
Page","number":213438,"url":"https://github.com/elastic/kibana/pull/213438","mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213438","number":213438,"mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 13, 2025
…214168)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Siem Migrations] Add Translated Rules Empty Page
(#213438)](#213438)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T13:59:12Z","message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ExpressionLanguage","release_note:skip","v9.0.0","Team:Threat
Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Siem
Migrations] Add Translated Rules Empty
Page","number":213438,"url":"https://github.com/elastic/kibana/pull/213438","mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213438","number":213438,"mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 13, 2025
…14169)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Siem Migrations] Add Translated Rules Empty Page
(#213438)](#213438)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T13:59:12Z","message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ExpressionLanguage","release_note:skip","v9.0.0","Team:Threat
Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Siem
Migrations] Add Translated Rules Empty
Page","number":213438,"url":"https://github.com/elastic/kibana/pull/213438","mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213438","number":213438,"mergeCommit":{"message":"[Siem
Migrations] Add Translated Rules Empty Page (#213438)\n\n##
Summary\n\nThis PR adds empty state for Translated Rules
Page.\n\n\n\nhttps://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056\n\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"bbc91a26917e0ad5257bfd879a0f1931d3442f25"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
## Summary

This PR adds empty state for Translated Rules Page.



https://github.com/user-attachments/assets/b8222151-526c-435e-b9bb-403e1097c056





### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants