Skip to content

[Onboarding] Hide card labels in search results#213417

Merged
mykolaharmash merged 2 commits intoelastic:mainfrom
mykolaharmash:200917-observability-onboarding-integration-cards-have-unverified-badges
Mar 7, 2025
Merged

[Onboarding] Hide card labels in search results#213417
mykolaharmash merged 2 commits intoelastic:mainfrom
mykolaharmash:200917-observability-onboarding-integration-cards-have-unverified-badges

Conversation

@mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Mar 6, 2025

Closes #200917

Looking at the code in Fleet search results screen, cards would also have the Unverified badges. (this check would return true because this specific page doesn't provides packageVerificationKeyId to the isPackageUnverified() function, this only happens on the individual integration details page. Fleet search just hides the badges for cards in search results.

This change aligns Onboarding search results with Fleet search results and hides the card labels which fixes the issue with Unverified badge appearing for installed integrations.

Before After
388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7 CleanShot 2025-03-07 at 14 35 53@2x

@mykolaharmash mykolaharmash requested a review from a team as a code owner March 6, 2025 15:57
@mykolaharmash mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting backport:version Backport to applied version labels v9.0.0 v8.18.0 v8.18.1 v8.17.4 ci:project-deploy-observability Create an Observability project Feature: Observability Onboarding and removed backport:skip This PR does not require backporting v8.18.1 labels Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mykolaharmash
Copy link
Contributor Author

/oblt-deploy

@mykolaharmash mykolaharmash added ci:project-deploy-observability Create an Observability project and removed ci:project-deploy-observability Create an Observability project labels Mar 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: c73c82f
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-213417-c73c82f696da

History

@yngrdyn
Copy link
Contributor

yngrdyn commented Mar 7, 2025

Would it be very nice for reviewers to get screenshots of before and after the changes

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, please consider the message about screenshots for future PRs

@mykolaharmash
Copy link
Contributor Author

Changes LGTM, please consider the message about screenshots for future PRs

Thank you @yngrdyn! I was waiting for the instance to be deployed to take screenshots there because the issue is not fully reproducible locally. Updated the description with screenshots.

@mykolaharmash mykolaharmash merged commit 33f71ae into elastic:main Mar 7, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13722988335

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 7, 2025
Closes elastic#200917

Looking at the code in Fleet search results screen, cards would also
have the `Unverified` badges. ([this
check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)
would return `true` because this specific page doesn't provides
`packageVerificationKeyId` to the `isPackageUnverified()` function, this
only happens on the individual integration details page. Fleet search
just [hides the
badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)
for cards in search results.

This change aligns Onboarding search results with Fleet search results
and hides the card labels which fixes the issue with `Unverified` badge
appearing for installed integrations.

| Before | After |
| --- | --- |
|
![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)
| ![CleanShot 2025-03-07 at 14 35
53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)
|

(cherry picked from commit 33f71ae)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 213417

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 7, 2025
)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Onboarding] Hide card labels in search results
(#213417)](#213417)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Feature:
Observability
Onboarding","backport:version","v8.18.0","v9.1.0","v8.17.4"],"title":"[Onboarding]
Hide card labels in search
results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
Closes elastic#200917

Looking at the code in Fleet search results screen, cards would also
have the `Unverified` badges. ([this
check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)
would return `true` because this specific page doesn't provides
`packageVerificationKeyId` to the `isPackageUnverified()` function, this
only happens on the individual integration details page. Fleet search
just [hides the
badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)
for cards in search results.

This change aligns Onboarding search results with Fleet search results
and hides the card labels which fixes the issue with `Unverified` badge
appearing for installed integrations.

| Before | After |
| --- | --- |
|
![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)
| ![CleanShot 2025-03-07 at 14 35
53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)
|
@awahab07
Copy link
Contributor

awahab07 commented Apr 1, 2025

💚 All backports created successfully

Status Branch Result
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@awahab07
Copy link
Contributor

awahab07 commented Apr 1, 2025

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@flash1293
Copy link
Contributor

flash1293 commented Apr 2, 2025

@awahab07 @mykolaharmash do we really need to backport this to 8.17? What's the reasoning here?

@awahab07
Copy link
Contributor

awahab07 commented Apr 2, 2025

@flash1293 I think we can do with only backporting to 8.18 as the backport of the PR #213911 depends on it.

For 8.17, it's just a tiny change, so I've created the backport anyway if we want to keep things in sync, but could be ignored if desired.

@flash1293
Copy link
Contributor

As this is not a critical fix, let's not backport it that far - just runs the risk of breaking things

@awahab07 awahab07 removed the v8.17.4 label Apr 7, 2025
awahab07 added a commit that referenced this pull request Apr 8, 2025
…6666)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Onboarding] Hide card labels in search results
(#213417)](#213417)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Feature:
Observability
Onboarding","backport:version","v8.18.0","v9.1.0","v8.17.4"],"title":"[Onboarding]
Hide card labels in search
results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213579","number":213579,"state":"MERGED","mergeCommit":{"sha":"ff5042eb811c5eb1eb6bccc797feec06f52e1e32","message":"[9.0]
[Onboarding] Hide card labels in search results (#213417) (#213579)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.0`:\n- [[Onboarding] Hide card labels in search
results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Mykola Harmash
<mykola.harmash@gmail.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 9, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@mykolaharmash mykolaharmash removed backport:version Backport to applied version labels v9.0.0 v8.18.0 labels Apr 10, 2025
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 10, 2025
@gbamparop
Copy link
Contributor

As this is not a critical fix, let's not backport it that far - just runs the risk of breaking things

@mykolaharmash doesn't this need a backport to 8.19?

@mykolaharmash
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@mykolaharmash
Copy link
Contributor Author

As this is not a critical fix, let's not backport it that far - just runs the risk of breaking things

@mykolaharmash doesn't this need a backport to 8.19?

Yes, good point, created a 8.x backport, @awahab07 could you please approve? Thank you!

mykolaharmash added a commit to mykolaharmash/kibana that referenced this pull request Apr 11, 2025
Closes elastic#200917

Looking at the code in Fleet search results screen, cards would also
have the `Unverified` badges. ([this
check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)
would return `true` because this specific page doesn't provides
`packageVerificationKeyId` to the `isPackageUnverified()` function, this
only happens on the individual integration details page. Fleet search
just [hides the
badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)
for cards in search results.

This change aligns Onboarding search results with Fleet search results
and hides the card labels which fixes the issue with `Unverified` badge
appearing for installed integrations.

| Before | After |
| --- | --- |
|
![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)
| ![CleanShot 2025-03-07 at 14 35
53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)
|

(cherry picked from commit 33f71ae)
mykolaharmash added a commit that referenced this pull request Apr 11, 2025
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Onboarding] Hide card labels in search results
(#213417)](#213417)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","ci:project-deploy-observability","Feature:
Observability Onboarding","v9.1.0"],"title":"[Onboarding] Hide card
labels in search
results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding]
Hide card labels in search results (#213417)\n\nCloses
https://github.com/elastic/kibana/issues/200917\n\nLooking at the code
in Fleet search results screen, cards would also\nhave the `Unverified`
badges.
([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould
return `true` because this specific page doesn't
provides\n`packageVerificationKeyId` to the `isPackageUnverified()`
function, this\nonly happens on the individual integration details page.
Fleet search\njust [hides
the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor
cards in search results.\n\nThis change aligns Onboarding search results
with Fleet search results\nand hides the card labels which fixes the
issue with `Unverified` badge\nappearing for installed
integrations.\n\n| Before | After |\n| --- | ---
|\n|\n![388110694-bd6abaf4-15ac-4d56-b556-fddb11c85ba7](https://github.com/user-attachments/assets/751a6572-192c-45f6-bfa8-82433b73398d)\n|
![CleanShot 2025-03-07 at 14
35\n53@2x](https://github.com/user-attachments/assets/d1588d7d-eec8-4207-a1e6-9a53272bbddf)\n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"url":"https://github.com/elastic/kibana/pull/213579","number":213579,"branch":"9.0","state":"MERGED","mergeCommit":{"sha":"ff5042eb811c5eb1eb6bccc797feec06f52e1e32","message":"[9.0]
[Onboarding] Hide card labels in search results (#213417) (#213579)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.0`:\n- [[Onboarding] Hide card labels in search
results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Mykola Harmash
<mykola.harmash@gmail.com>"}},{"url":"https://github.com/elastic/kibana/pull/216666","number":216666,"branch":"8.18","state":"MERGED","mergeCommit":{"sha":"ca96f071c305f6b66f15bc8cb0ce17e49cf94b9e","message":"[8.18]
[Onboarding] Hide card labels in search results (#213417) (#216666)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.18`:\n- [[Onboarding] Hide card labels in search
results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by:
Mykola Harmash
<mykola.harmash@gmail.com>"}},{"url":"https://github.com/elastic/kibana/pull/216689","number":216689,"branch":"8.17","state":"OPEN"}]}]
BACKPORT-->
@mistic mistic added the v8.18.0 label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project Feature: Observability Onboarding release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Observability Onboarding] Integration cards have "Unverified" badges

8 participants