[Onboarding] Hide card labels in search results#213417
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/oblt-deploy |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…cards-have-unverified-badges
⏳ Build in-progress
History
|
|
Would it be very nice for reviewers to get screenshots of |
yngrdyn
left a comment
There was a problem hiding this comment.
Changes LGTM, please consider the message about screenshots for future PRs
...ns/observability_onboarding/public/application/onboarding_flow_form/onboarding_flow_form.tsx
Show resolved
Hide resolved
Thank you @yngrdyn! I was waiting for the instance to be deployed to take screenshots there because the issue is not fully reproducible locally. Updated the description with screenshots. |
|
Starting backport for target branches: 8.17, 8.18, 9.0 https://github.com/elastic/kibana/actions/runs/13722988335 |
Closes elastic#200917 Looking at the code in Fleet search results screen, cards would also have the `Unverified` badges. ([this check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101) would return `true` because this specific page doesn't provides `packageVerificationKeyId` to the `isPackageUnverified()` function, this only happens on the individual integration details page. Fleet search just [hides the badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188) for cards in search results. This change aligns Onboarding search results with Fleet search results and hides the card labels which fixes the issue with `Unverified` badge appearing for installed integrations. | Before | After | | --- | --- | |  |  | (cherry picked from commit 33f71ae)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
) # Backport This will backport the following commits from `main` to `9.0`: - [[Onboarding] Hide card labels in search results (#213417)](#213417) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Feature: Observability Onboarding","backport:version","v8.18.0","v9.1.0","v8.17.4"],"title":"[Onboarding] Hide card labels in search results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
Closes elastic#200917 Looking at the code in Fleet search results screen, cards would also have the `Unverified` badges. ([this check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101) would return `true` because this specific page doesn't provides `packageVerificationKeyId` to the `isPackageUnverified()` function, this only happens on the individual integration details page. Fleet search just [hides the badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188) for cards in search results. This change aligns Onboarding search results with Fleet search results and hides the card labels which fixes the issue with `Unverified` badge appearing for installed integrations. | Before | After | | --- | --- | |  |  |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
@awahab07 @mykolaharmash do we really need to backport this to 8.17? What's the reasoning here? |
|
@flash1293 I think we can do with only backporting to For |
|
As this is not a critical fix, let's not backport it that far - just runs the risk of breaking things |
…6666) # Backport This will backport the following commits from `main` to `8.18`: - [[Onboarding] Hide card labels in search results (#213417)](#213417) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Feature: Observability Onboarding","backport:version","v8.18.0","v9.1.0","v8.17.4"],"title":"[Onboarding] Hide card labels in search results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213579","number":213579,"state":"MERGED","mergeCommit":{"sha":"ff5042eb811c5eb1eb6bccc797feec06f52e1e32","message":"[9.0] [Onboarding] Hide card labels in search results (#213417) (#213579)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Onboarding] Hide card labels in search results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Mykola Harmash <mykola.harmash@gmail.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
@mykolaharmash doesn't this need a backport to 8.19? |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Yes, good point, created a 8.x backport, @awahab07 could you please approve? Thank you! |
Closes elastic#200917 Looking at the code in Fleet search results screen, cards would also have the `Unverified` badges. ([this check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101) would return `true` because this specific page doesn't provides `packageVerificationKeyId` to the `isPackageUnverified()` function, this only happens on the individual integration details page. Fleet search just [hides the badges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188) for cards in search results. This change aligns Onboarding search results with Fleet search results and hides the card labels which fixes the issue with `Unverified` badge appearing for installed integrations. | Before | After | | --- | --- | |  |  | (cherry picked from commit 33f71ae)
) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] Hide card labels in search results (#213417)](#213417) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-03-07T14:40:39Z","message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","ci:project-deploy-observability","Feature: Observability Onboarding","v9.1.0"],"title":"[Onboarding] Hide card labels in search results","number":213417,"url":"https://github.com/elastic/kibana/pull/213417","mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213417","number":213417,"mergeCommit":{"message":"[Onboarding] Hide card labels in search results (#213417)\n\nCloses https://github.com/elastic/kibana/issues/200917\n\nLooking at the code in Fleet search results screen, cards would also\nhave the `Unverified` badges. ([this\ncheck](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx#L101)\nwould return `true` because this specific page doesn't provides\n`packageVerificationKeyId` to the `isPackageUnverified()` function, this\nonly happens on the individual integration details page. Fleet search\njust [hides the\nbadges](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx#L188)\nfor cards in search results.\n\nThis change aligns Onboarding search results with Fleet search results\nand hides the card labels which fixes the issue with `Unverified` badge\nappearing for installed integrations.\n\n| Before | After |\n| --- | --- |\n|\n\n| \n|","sha":"33f71ae678e833b4c91325e40f47d819e1edb08d"}},{"url":"https://github.com/elastic/kibana/pull/213579","number":213579,"branch":"9.0","state":"MERGED","mergeCommit":{"sha":"ff5042eb811c5eb1eb6bccc797feec06f52e1e32","message":"[9.0] [Onboarding] Hide card labels in search results (#213417) (#213579)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Onboarding] Hide card labels in search results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Mykola Harmash <mykola.harmash@gmail.com>"}},{"url":"https://github.com/elastic/kibana/pull/216666","number":216666,"branch":"8.18","state":"MERGED","mergeCommit":{"sha":"ca96f071c305f6b66f15bc8cb0ce17e49cf94b9e","message":"[8.18] [Onboarding] Hide card labels in search results (#213417) (#216666)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [[Onboarding] Hide card labels in search results\n(#213417)](https://github.com/elastic/kibana/pull/213417)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: Mykola Harmash <mykola.harmash@gmail.com>"}},{"url":"https://github.com/elastic/kibana/pull/216689","number":216689,"branch":"8.17","state":"OPEN"}]}] BACKPORT-->
Closes #200917
Looking at the code in Fleet search results screen, cards would also have the
Unverifiedbadges. (this check would returntruebecause this specific page doesn't providespackageVerificationKeyIdto theisPackageUnverified()function, this only happens on the individual integration details page. Fleet search just hides the badges for cards in search results.This change aligns Onboarding search results with Fleet search results and hides the card labels which fixes the issue with
Unverifiedbadge appearing for installed integrations.