[ML] Anomaly Detection: Show Switch to apply time range when opening job selector from left nav#213382
Merged
rbrtj merged 5 commits intoelastic:mainfrom Mar 11, 2025
Merged
Conversation
rbrtj
added
release_note:fix
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Mar 10, 2025
...latform/plugins/shared/ml/public/application/components/job_selector/job_selector_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/ml/public/application/contexts/ml/use_job_selection_flyout.tsx
Show resolved
Hide resolved
peteharverson
approved these changes
Mar 10, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM. I can no longer reproduce the workflow issues captured in the two issues you linked to in the description.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @rbrtj |
darnautov
approved these changes
Mar 11, 2025
Contributor
darnautov
left a comment
darnautov
left a comment
There was a problem hiding this comment.
LGTM, and thanks for doing the refactoring 🙌🏻
Contributor
|
Starting backport for target branches: 8.18, 9.0 https://github.com/elastic/kibana/actions/runs/13789712782 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2025
…g job selector from left nav (elastic#213382) Fix for: elastic#211018 and elastic#212407 Note: Previously, the `apply time range` setting was saved in local storage even if the changes were not applied. After the fix, the setting is saved in local storage only if the user applies the new selection. After: https://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55 (cherry picked from commit cbcb7ed)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2025
…g job selector from left nav (elastic#213382) Fix for: elastic#211018 and elastic#212407 Note: Previously, the `apply time range` setting was saved in local storage even if the changes were not applied. After the fix, the setting is saved in local storage only if the user applies the new selection. After: https://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55 (cherry picked from commit cbcb7ed)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2025
…opening job selector from left nav (#213382) (#213925) # Backport This will backport the following commits from `main` to `9.0`: - [[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)](#213382) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-11T13:50:52Z","message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","v9.0.0","Team:ML","backport:version","v8.18.0","v9.1.0"],"title":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav","number":213382,"url":"https://github.com/elastic/kibana/pull/213382","mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213382","number":213382,"mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2025
… opening job selector from left nav (#213382) (#213924) # Backport This will backport the following commits from `main` to `8.18`: - [[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)](#213382) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-11T13:50:52Z","message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","v9.0.0","Team:ML","backport:version","v8.18.0","v9.1.0"],"title":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav","number":213382,"url":"https://github.com/elastic/kibana/pull/213382","mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213382","number":213382,"mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
rbrtj
added
backport:version
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13792582406 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2025
…g job selector from left nav (elastic#213382) Fix for: elastic#211018 and elastic#212407 Note: Previously, the `apply time range` setting was saved in local storage even if the changes were not applied. After the fix, the setting is saved in local storage only if the user applies the new selection. After: https://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55 (cherry picked from commit cbcb7ed)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2025
…opening job selector from left nav (#213382) (#213965) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)](#213382) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-11T13:50:52Z","message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","v9.0.0","Team:ML","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav","number":213382,"url":"https://github.com/elastic/kibana/pull/213382","mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213925","number":213925,"state":"MERGED","mergeCommit":{"sha":"c68d82ee86e69ed23813c1024770626c5b98f285","message":"[9.0] [ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382) (#213925)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[ML] Anomaly Detection: Show `Switch to apply time range` when\nopening job selector from left nav\n(#213382)](https://github.com/elastic/kibana/pull/213382)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213924","number":213924,"state":"MERGED","mergeCommit":{"sha":"f41478f8e519752dd50608df22bb591aba4b3087","message":"[8.18] [ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382) (#213924)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [[ML] Anomaly Detection: Show `Switch to apply time range` when\nopening job selector from left nav\n(#213382)](https://github.com/elastic/kibana/pull/213382)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213382","number":213382,"mergeCommit":{"message":"[ML] Anomaly Detection: Show `Switch to apply time range` when opening job selector from left nav (#213382)\n\nFix for: #211018 and\nhttps://github.com//issues/212407\n\nNote: Previously, the `apply time range` setting was saved in local\nstorage even if the changes were not applied. After the fix, the setting\nis saved in local storage only if the user applies the new selection.\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55","sha":"cbcb7edb94e44bc8edc1a4e6f21bff5504c4d61a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…g job selector from left nav (elastic#213382) Fix for: elastic#211018 and elastic#212407 Note: Previously, the `apply time range` setting was saved in local storage even if the changes were not applied. After the fix, the setting is saved in local storage only if the user applies the new selection. After: https://github.com/user-attachments/assets/1657f0f4-c580-4941-9582-bf5f9dc3cd55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #211018 and #212407
Note: Previously, the
apply time rangesetting was saved in local storage even if the changes were not applied. After the fix, the setting is saved in local storage only if the user applies the new selection.After:
Screen.Recording.2025-03-06.at.13.39.30.mov