relax threshold for flaky regionmap test#21305
Merged
thomasneirynck merged 1 commit intoelastic:masterfrom Jul 27, 2018
Merged
Conversation
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
Contributor
Author
|
jenkins, test this |
kindsun
approved these changes
Jul 26, 2018
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
Tested locally and tests passed. This adjustment seems reasonable given env differences that might cause pixel rendering differences.
Contributor
💚 Build Succeeded |
Contributor
Author
|
jenkins, test this |
thomasneirynck
added
test
Feature:Region Map
v7.0.0
Team:Geo
Contributor
💚 Build Succeeded |
Contributor
Author
|
this succeeded a couple of times now. will merge. |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2018
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2018
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 27, 2018
thomasneirynck
added a commit
that referenced
this pull request
Jul 27, 2018
thomasneirynck
added a commit
that referenced
this pull request
Jul 27, 2018
thomasneirynck
added a commit
that referenced
this pull request
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxing the threshold seems to fix the screenshot comparison. Could not reproduce this locally, so probably a slight change in the CI environment causing the diffs.