Skip to content

[8.x] [Security Assistant] Conversation pagination refactor (#211831)#212997

Merged
stephmilovic merged 2 commits intoelastic:8.xfrom
stephmilovic:backport/8.x/pr-211831
Mar 4, 2025
Merged

[8.x] [Security Assistant] Conversation pagination refactor (#211831)#212997
stephmilovic merged 2 commits intoelastic:8.xfrom
stephmilovic:backport/8.x/pr-211831

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 095fc22)

# Conflicts:
#	x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/assistant_header/index.tsx
#	x-pack/platform/packages/shared/kbn-elastic-assistant/impl/connectorland/connector_selector_inline/connector_selector_inline.tsx
#	x-pack/platform/packages/shared/kbn-elastic-assistant/impl/data_anonymization/settings/anonymization_settings_management/index.tsx
#	x-pack/solutions/security/plugins/elastic_assistant/server/ai_assistant_data_clients/find.ts
@stephmilovic stephmilovic added the backport This PR is a backport of another PR label Mar 3, 2025
@stephmilovic stephmilovic enabled auto-merge (squash) March 3, 2025 22:45
@stephmilovic stephmilovic merged commit b939da0 into elastic:8.x Mar 4, 2025
8 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 499 490 -9
securitySolution 7117 7110 -7
total -16

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 144 135 -9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 864.3KB 864.1KB -154.0B
securitySolution 9.1MB 9.1MB -12.5KB
total -12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 83.9KB 83.5KB -364.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 172 164 -8

ESLint disabled line counts

id before after diff
@kbn/elastic-assistant 14 13 -1

Total ESLint disabled count

id before after diff
@kbn/elastic-assistant 15 14 -1

History

SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…211831) (elastic#212997)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Assistant] Conversation pagination refactor
(elastic#211831)](elastic#211831)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T20:41:20Z","message":"[Security
Assistant] Conversation pagination refactor
(elastic#211831)","sha":"095fc222aa541bf50f57c11958c16eb4c04a282c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v9.1.0","v8.19.0"],"title":"[Security Assistant]
Conversation pagination
refactor","number":211831,"url":"https://github.com/elastic/kibana/pull/211831","mergeCommit":{"message":"[Security
Assistant] Conversation pagination refactor
(elastic#211831)","sha":"095fc222aa541bf50f57c11958c16eb4c04a282c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211831","number":211831,"mergeCommit":{"message":"[Security
Assistant] Conversation pagination refactor
(elastic#211831)","sha":"095fc222aa541bf50f57c11958c16eb4c04a282c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants