Skip to content

[Spaces] - Introducing Space Identifier, Forgetting URL Context #21295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legrego merged 5 commits into from
Jul 27, 2018
Merged

[Spaces] - Introducing Space Identifier, Forgetting URL Context #21295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13b213d
Remove urlContext in favor of a public space identifier
legrego Jul 26, 2018
7163f34
space description should be optional
legrego Jul 26, 2018
90a699e
update functional tests
legrego Jul 26, 2018
7fb1bad
remove stray console statement
legrego Jul 26, 2018
b5c090c
address PR feedback
legrego Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x-pack/plugins/spaces/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
}
}
},
"urlContext": {
"type": "keyword"
},
"description": {
"type": "text"
},
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/spaces/public/views/components/space_card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ function renderSpaceAvatar(space) {
}

function renderSpaceDescription(space) {
let description = space.description;
const needsTruncation = space.description.length > 120;
let description = space.description || '';
const needsTruncation = description.length > 120;
if (needsTruncation) {
description = (
<span title={description}>{space.description.substr(0, 120) + '…'}</span>
<span title={description}>{description.substr(0, 120) + '…'}</span>
);
}
return <EuiTextColor className="eui-textBreakWord" color={"subdued"}>{description}</EuiTextColor>;
Expand Down
24 changes: 11 additions & 13 deletions ...ce/__snapshots__/url_context.test.js.snap → ...snapshots__/space_identifier.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`renders without crashing 1`] = `
isInvalid={false}
label={
<p>
URL Context
Space Identifier
<EuiLink
color="primary"
onClick={[Function]}
Expand All @@ -25,18 +25,16 @@ exports[`renders without crashing 1`] = `
</p>
}
>
<div>
<EuiFieldText
compressed={false}
fullWidth={false}
inputRef={[Function]}
isLoading={false}
onChange={[Function]}
placeholder="give your space a name to see its URL Context"
readOnly={true}
value=""
/>
</div>
<EuiFieldText
compressed={false}
fullWidth={false}
inputRef={[Function]}
isLoading={false}
onChange={[Function]}
placeholder="give your space a name to see its identifier"
readOnly={true}
value=""
/>
</EuiFormRow>
</React.Fragment>
`;
Loading