[9.0] [Security Solution] Fixed Table height row rendering - Event Rendered View (#212130)#212600
Merged
PhilippeOberti merged 1 commit intoelastic:9.0from Feb 27, 2025
Merged
Conversation
9 tasks
… View (elastic#212130) ## Summary Today Alert table has a height of 600px if the number of items it displays exceeds 20. If not, it has a height of `auto` which means it adjust the table height according to the number of rows displayed. This height `auto` surfaces an issue with EuiDataGrid where it is not able to calculate the height of the displayed rows. This results in arbitrary height everytime the number of rows < 20. ## Solution We are working with EUI Team to permanently fix the issue. But as a workaround, we are setting up a fixed height of EuiDataGrid to `600px` irrespective of the number of rows that are visible on the screen. This would sometime lead of extra flush space visible as can be seen in below demo. But it ensures that user is never in an unusable state. Below is the summary of changes applied - Fixed height of `600px` in case of Event Rendered View Below `Before` and `After` Sections show the demo ### Before https://github.com/user-attachments/assets/6efd70b1-a33f-4c98-bd8f-82f57e9cd0cd ### After https://github.com/user-attachments/assets/8da31611-12ff-4609-bafb-4b0f53398407 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co> (cherry picked from commit 88ab8b6) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/index.tsx
PhilippeOberti
force-pushed
the
backport/9.0/pr-212130
branch
from
7145320 to
ecb531b
Compare
Contributor
Author
|
Here the comparison before fix and after fix. Before9.0-no_fix.movAfter9.0-fix.mov |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History |
kqualters-elastic
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation