Merged
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
nreese
added
release_note:enhancement
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Any counts in public APIs
Async chunks
Unknown metric groupsAPI count
miscellaneous assets size
History
|
nickpeihl
approved these changes
Mar 3, 2025
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! Code review and tested multiple layer types. The source/destination maps look amazing.
And it looks like embedded maps can even use the projection: 'globeInterpolation' setting. (I hacked in a change to test this in Lens choropleth charts 😄 )
Mar-03-2025.15-50-36.mp4
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13644234330 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 4, 2025
<img width="600" alt="Screenshot 2025-02-25 at 11 35 32 AM" src="https://github.com/user-attachments/assets/2567e20c-1223-4001-9866-edbe8c534350" /> PR does the following * Updates maplibre to 5.1.1. Maplibre 5.0 introduced the globe projection * Updates sample data maps to use new globe projection * Existing maps will use existing "mercator" projection * Adds globe projection to newly created maps * Adds `projection` setting, allowing users to switch between classic "mercator" and new "globeInterpolate" projection <img width="400" alt="Screenshot 2025-02-25 at 11 35 41 AM" src="https://github.com/user-attachments/assets/5c55003b-dbe9-4adc-835c-0a2911c81074" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 037e8f5) # Conflicts: # x-pack/platform/plugins/shared/maps/public/classes/sources/ems_tms_source/ems_tms_source.tsx # yarn.lock
nreese
added a commit
that referenced
this pull request
Mar 4, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[maps] globe projection (#212437)](#212437) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-03-04T01:31:05Z","message":"[maps] globe projection (#212437)\n\n<img width=\"600\" alt=\"Screenshot 2025-02-25 at 11 35 32 AM\"\nsrc=\"https://github.com/user-attachments/assets/2567e20c-1223-4001-9866-edbe8c534350\"\n/>\n\nPR does the following\n* Updates maplibre to 5.1.1. Maplibre 5.0 introduced the globe\nprojection\n* Updates sample data maps to use new globe projection\n* Existing maps will use existing \"mercator\" projection\n* Adds globe projection to newly created maps\n* Adds `projection` setting, allowing users to switch between classic\n\"mercator\" and new \"globeInterpolate\" projection\n<img width=\"400\" alt=\"Screenshot 2025-02-25 at 11 35 41 AM\"\nsrc=\"https://github.com/user-attachments/assets/5c55003b-dbe9-4adc-835c-0a2911c81074\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"037e8f58e0af20b006243ee1f28b4d1e5414ab8d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Presentation","Feature:Maps","backport:version","v9.1.0","v8.19.0"],"title":"[maps] globe projection","number":212437,"url":"https://github.com/elastic/kibana/pull/212437","mergeCommit":{"message":"[maps] globe projection (#212437)\n\n<img width=\"600\" alt=\"Screenshot 2025-02-25 at 11 35 32 AM\"\nsrc=\"https://github.com/user-attachments/assets/2567e20c-1223-4001-9866-edbe8c534350\"\n/>\n\nPR does the following\n* Updates maplibre to 5.1.1. Maplibre 5.0 introduced the globe\nprojection\n* Updates sample data maps to use new globe projection\n* Existing maps will use existing \"mercator\" projection\n* Adds globe projection to newly created maps\n* Adds `projection` setting, allowing users to switch between classic\n\"mercator\" and new \"globeInterpolate\" projection\n<img width=\"400\" alt=\"Screenshot 2025-02-25 at 11 35 41 AM\"\nsrc=\"https://github.com/user-attachments/assets/5c55003b-dbe9-4adc-835c-0a2911c81074\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"037e8f58e0af20b006243ee1f28b4d1e5414ab8d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212437","number":212437,"mergeCommit":{"message":"[maps] globe projection (#212437)\n\n<img width=\"600\" alt=\"Screenshot 2025-02-25 at 11 35 32 AM\"\nsrc=\"https://github.com/user-attachments/assets/2567e20c-1223-4001-9866-edbe8c534350\"\n/>\n\nPR does the following\n* Updates maplibre to 5.1.1. Maplibre 5.0 introduced the globe\nprojection\n* Updates sample data maps to use new globe projection\n* Existing maps will use existing \"mercator\" projection\n* Adds globe projection to newly created maps\n* Adds `projection` setting, allowing users to switch between classic\n\"mercator\" and new \"globeInterpolate\" projection\n<img width=\"400\" alt=\"Screenshot 2025-02-25 at 11 35 41 AM\"\nsrc=\"https://github.com/user-attachments/assets/5c55003b-dbe9-4adc-835c-0a2911c81074\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"037e8f58e0af20b006243ee1f28b4d1e5414ab8d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
1 task
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
<img width="600" alt="Screenshot 2025-02-25 at 11 35 32 AM" src="https://github.com/user-attachments/assets/2567e20c-1223-4001-9866-edbe8c534350" /> PR does the following * Updates maplibre to 5.1.1. Maplibre 5.0 introduced the globe projection * Updates sample data maps to use new globe projection * Existing maps will use existing "mercator" projection * Adds globe projection to newly created maps * Adds `projection` setting, allowing users to switch between classic "mercator" and new "globeInterpolate" projection <img width="400" alt="Screenshot 2025-02-25 at 11 35 41 AM" src="https://github.com/user-attachments/assets/5c55003b-dbe9-4adc-835c-0a2911c81074" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR does the following
projectionsetting, allowing users to switch between classic "mercator" and new "globeInterpolate" projection