Always use EMS production url, even in dev#21237
Merged
thomasneirynck merged 2 commits intoelastic:masterfrom Jul 26, 2018
Merged
Always use EMS production url, even in dev#21237thomasneirynck merged 2 commits intoelastic:masterfrom
thomasneirynck merged 2 commits intoelastic:masterfrom
Conversation
thomasneirynck
added
v7.0.0
v6.4.0
v6.5.0
v6.3.3
chore
Team:Geo
Merged
nickpeihl
requested changes
Jul 25, 2018
src/server/config/schema.js
Outdated
| then: Joi.string().default('https://staging-dot-catalogue-dot-elastic-layer.appspot.com/v2/manifest'), | ||
| otherwise: Joi.string().default('https://catalogue.maps.elastic.co/v2/manifest') | ||
| }), | ||
| manifestServiceUrl: Joi.string().default('https://staging-dot-catalogue-dot-elastic-layer.appspot.com/v2/manifest'), |
Contributor
There was a problem hiding this comment.
Shouldn't this be https://catalogue.maps.elastic.co/v2/manifest? Or did I miss something?
Contributor
Author
There was a problem hiding this comment.
😊 damn ok thx
nickpeihl
approved these changes
Jul 25, 2018
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 26, 2018
This makes usage of EMS more predictable in Kibana, showing vetted production-ready data consistently
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 26, 2018
This makes usage of EMS more predictable in Kibana, showing vetted production-ready data consistently
This was referenced Jul 26, 2018
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 26, 2018
This makes usage of EMS more predictable in Kibana, showing vetted production-ready data consistently
thomasneirynck
added a commit
that referenced
this pull request
Jul 26, 2018
thomasneirynck
added a commit
that referenced
this pull request
Jul 26, 2018
thomasneirynck
added a commit
that referenced
this pull request
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes usage of EMS more predictable in Kibana, showing vetted production-ready data consistently.
If users want to use the staging version of EMS, which includes different test datasets, they can either configure the
manifestServiceUrlsetting manually, or host the vector layers themselves and configuring theregionmap.layerssetting