[Security Assistant] Fix markdown syntax highlighting #212333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
patrykkopycinski
changed the title
patrykkopycinski
added
release_note:skip
Member
|
/ci |
Member
|
For me JSON is getting highlighted but ESQL is not... 
The message content shows the language is specified: 
|
Contributor
Author
|
that's expected, it will work after this PR gets merged #211671 |
Contributor
Author
|
@KDKHD would you mind to retest? |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13579097224 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 28, 2025
## Summary Implements elastic/eui#8317 Before: <img width="1007" alt="image" src="https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f" /> After: <img width="1484" alt="image" src="https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727" /> (cherry picked from commit f8ba372)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 28, 2025
## Summary Implements elastic/eui#8317 Before: <img width="1007" alt="image" src="https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f" /> After: <img width="1484" alt="image" src="https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727" /> (cherry picked from commit f8ba372)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 28, 2025
## Summary Implements elastic/eui#8317 Before: <img width="1007" alt="image" src="https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f" /> After: <img width="1484" alt="image" src="https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727" /> (cherry picked from commit f8ba372)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 28, 2025
#212708) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Assistant] Fix markdown syntax highlighting (#212333)](#212333) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-28T01:05:34Z","message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Assistant] Fix markdown syntax highlighting","number":212333,"url":"https://github.com/elastic/kibana/pull/212333","mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212333","number":212333,"mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 28, 2025
…#212709) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Fix markdown syntax highlighting (#212333)](#212333) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-28T01:05:34Z","message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Assistant] Fix markdown syntax highlighting","number":212333,"url":"https://github.com/elastic/kibana/pull/212333","mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212333","number":212333,"mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 28, 2025
…#212710) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Assistant] Fix markdown syntax highlighting (#212333)](#212333) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-28T01:05:34Z","message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Assistant] Fix markdown syntax highlighting","number":212333,"url":"https://github.com/elastic/kibana/pull/212333","mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212333","number":212333,"mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…212333) (elastic#212709) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Fix markdown syntax highlighting (elastic#212333)](elastic#212333) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-28T01:05:34Z","message":"[Security Assistant] Fix markdown syntax highlighting (elastic#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Assistant] Fix markdown syntax highlighting","number":212333,"url":"https://github.com/elastic/kibana/pull/212333","mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (elastic#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212333","number":212333,"mergeCommit":{"message":"[Security Assistant] Fix markdown syntax highlighting (elastic#212333)\n\n## Summary\nImplements elastic/eui#8317 \n\nBefore: \n<img width=\"1007\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f\"\n/>\n\nAfter:\n<img width=\"1484\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727\"\n/>","sha":"f8ba3721061de8fe5789eaeb59fcf94b99f0fc05"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary Implements elastic/eui#8317 Before: <img width="1007" alt="image" src="https://github.com/user-attachments/assets/649a075a-7338-434b-9e2e-4c4fd0d6ca6f" /> After: <img width="1484" alt="image" src="https://github.com/user-attachments/assets/cdb27885-e009-49aa-9b1a-381e12c33727" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements elastic/eui#8317
Before:
After:
