Skip to content

[8.x] Siem Migrations - Fix rules upload API Error Test. (#212290) #212301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 2 commits into from
Feb 28, 2025
Merged

[8.x] Siem Migrations - Fix rules upload API Error Test. (#212290) #212301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce982f8
Siem Migrations - Fix rules upload API Error Test. (#212290)
logeekal Feb 24, 2025
a6205e0
Merge branch '8.x' into backport/8.x/pr-212290
logeekal Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions ...ents/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,42 +132,16 @@ describe('RulesFileUpload', () => {
},
];

it('should not be able to upload on API Error', async () => {
it('should display API Error', async () => {
renderTestComponent({
apiError: mockApiError,
});

const fileName = 'splunk_rules.test.data.json';
const ndJSONString = splunkTestRules.map((obj) => JSON.stringify(obj)).join('\n');
const testFile = createRulesFileFromRulesData(ndJSONString, getTestDir(), fileName);

const filePicker = screen.getByTestId('rulesFilePicker');

act(() => {
fireEvent.change(filePicker, {
target: {
files: [testFile],
},
});
});

await waitFor(() => {
expect(filePicker).toHaveAttribute('data-loading', 'true');
});

await waitFor(() => {
expect(filePicker).toHaveAttribute('data-loading', 'false');
});

await act(async () => {
fireEvent.click(screen.getByTestId('uploadFileButton'));
});

await waitFor(() => {
expect(screen.getByText(mockApiError)).toBeVisible();
expect(screen.getByTestId('uploadFileButton')).toBeDisabled();
});
});

scenarios.forEach((scenario, _idx) => {
it(`should not be able to upload when file has - ${scenario.subject}`, async () => {
const fileName = 'invalid_rule_file.json';
Expand Down