[8.18] Siem Migrations - Fix rules upload API Error Test. (#212290)#212300
Merged
kibanamachine merged 1 commit intoelastic:8.18from Feb 24, 2025
Merged
[8.18] Siem Migrations - Fix rules upload API Error Test. (#212290)#212300kibanamachine merged 1 commit intoelastic:8.18from
kibanamachine merged 1 commit intoelastic:8.18from
Conversation
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 681cef4)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
Contributor
💚 Build Succeeded
Metrics [docs]
cc @logeekal |
logeekal
added a commit
that referenced
this pull request
Feb 28, 2025
…212712) # Backport This will backport the following commits from `main` to `9.0`: - [ Siem Migrations - Fix rules upload API Error Test. (#212290)](#212290) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-02-24T18:59:41Z","message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":" Siem Migrations - Fix rules upload API Error Test.","number":212290,"url":"https://github.com/elastic/kibana/pull/212290","mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212300","number":212300,"state":"MERGED","mergeCommit":{"sha":"797a695ae413cb28c52fe238432e9686cb218ad9","message":"[8.18] Siem Migrations - Fix rules upload API Error Test. (#212290) (#212300)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [ Siem Migrations - Fix rules upload API Error Test.\n(#212290)](https://github.com/elastic/kibana/pull/212290)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212290","number":212290,"mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212301","number":212301,"state":"OPEN"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation