Skip to content

Attempt to fix AlertSummaryWidget flaky test#212107

Merged
maryam-saeidi merged 2 commits intoelastic:mainfrom
maryam-saeidi:198102-fix-flaky-alert-summary-widget-test
Feb 25, 2025
Merged

Attempt to fix AlertSummaryWidget flaky test#212107
maryam-saeidi merged 2 commits intoelastic:mainfrom
maryam-saeidi:198102-fix-flaky-alert-summary-widget-test

Conversation

@maryam-saeidi
Copy link
Copy Markdown
Member

@maryam-saeidi maryam-saeidi commented Feb 21, 2025 •
edited by kibanamachine
Loading

Fixes #198102

Summary

The check that fails is related to status:All here:

expect(url.includes('status%3Aall')).to.be(true);

It seems the status is active from the previous step:

This PR adds a retry to accommodate a delay in changing URLs.

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 21, 2025
@maryam-saeidi maryam-saeidi self-assigned this Feb 21, 2025
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner February 21, 2025 15:24
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Feb 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dominiqueclarke
Copy link
Copy Markdown
Contributor

dominiqueclarke commented Feb 24, 2025

@maryam-saeidi did you run this against flaky test runner?

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2025

⏳ Build in-progress

  • Buildkite Build
  • Commit: 6a9a453
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-212107-6a9a453db2c1

History

cc @maryam-saeidi

@maryam-saeidi
Copy link
Copy Markdown
Member Author

maryam-saeidi commented Feb 25, 2025

@maryam-saeidi did you run this against flaky test runner?

Same as this comment.

dominiqueclarke
dominiqueclarke approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi merged commit 3b1c352 into elastic:main Feb 25, 2025
@maryam-saeidi maryam-saeidi deleted the 198102-fix-flaky-alert-summary-widget-test branch February 25, 2025 20:13
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
@maryam-saeidi @dominiqueclarke @JoseLuisGJ
Attempt to fix AlertSummaryWidget flaky test (elastic#212107)
cb31d7a 
Fixes elastic#198102

## Summary

The check that fails is related to status:All
[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):

```
expect(url.includes('status%3Aall')).to.be(true);
```

It seems the status is active from the previous step:

<img
src="https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598"
width=500 />


This PR adds a retry to accommodate a delay in changing URLs.

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@maryam-saeidi maryam-saeidi mentioned this pull request Mar 19, 2025
Closed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
@maryam-saeidi @dominiqueclarke @CAWilson94
Attempt to fix AlertSummaryWidget flaky test (elastic#212107)
3a002c6 
Fixes elastic#198102

## Summary

The check that fails is related to status:All
[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):

```
expect(url.includes('status%3Aall')).to.be(true);
```

It seems the status is active from the previous step:

<img
src="https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598"
width=500 />


This PR adds a retry to accommodate a delay in changing URLs.

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@maryam-saeidi maryam-saeidi added v9.0.2 v9.0.3 backport:version Backport to applied version labels and removed v9.0.2 backport:skip This PR does not require backporting labels May 28, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/15299242537

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/15299242531

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2025
@maryam-saeidi @dominiqueclarke
Attempt to fix AlertSummaryWidget flaky test (elastic#212107)
75090ab 
Fixes elastic#198102

## Summary

The check that fails is related to status:All
[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):

```
expect(url.includes('status%3Aall')).to.be(true);
```

It seems the status is active from the previous step:

<img
src="https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598"
width=500 />

This PR adds a retry to accommodate a delay in changing URLs.

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
(cherry picked from commit 3b1c352)
@kibanamachine kibanamachine mentioned this pull request May 28, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2025
@maryam-saeidi @dominiqueclarke
Attempt to fix AlertSummaryWidget flaky test (elastic#212107)
713946c 
Fixes elastic#198102

## Summary

The check that fails is related to status:All
[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):

```
expect(url.includes('status%3Aall')).to.be(true);
```

It seems the status is active from the previous step:

<img
src="https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598"
width=500 />

This PR adds a retry to accommodate a delay in changing URLs.

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
(cherry picked from commit 3b1c352)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 28, 2025
@kibanamachine @maryam-saeidi @dominiqueclarke
[9.0] Attempt to fix AlertSummaryWidget flaky test (#212107) (#221769)
e0e538b 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Attempt to fix AlertSummaryWidget flaky test
(#212107)](#212107)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-25T20:13:04Z","message":"Attempt
to fix AlertSummaryWidget flaky test (#212107)\n\nFixes #198102\n\n##
Summary\n\nThe check that fails is related to
status:All\n[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):\n\n```\nexpect(url.includes('status%3Aall')).to.be(true);\n```\n\nIt
seems the status is active from the previous
step:\n\n<img\nsrc=\"https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598\"\nwidth=500
/>\n\n\nThis PR adds a retry to accommodate a delay in changing
URLs.\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"3b1c352df9f4651f21d340133d1b6d91a2199604","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.1.0","v9.0.3"],"title":"Attempt
to fix AlertSummaryWidget flaky
test","number":212107,"url":"https://github.com/elastic/kibana/pull/212107","mergeCommit":{"message":"Attempt
to fix AlertSummaryWidget flaky test (#212107)\n\nFixes #198102\n\n##
Summary\n\nThe check that fails is related to
status:All\n[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):\n\n```\nexpect(url.includes('status%3Aall')).to.be(true);\n```\n\nIt
seems the status is active from the previous
step:\n\n<img\nsrc=\"https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598\"\nwidth=500
/>\n\n\nThis PR adds a retry to accommodate a delay in changing
URLs.\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"3b1c352df9f4651f21d340133d1b6d91a2199604"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212107","number":212107,"mergeCommit":{"message":"Attempt
to fix AlertSummaryWidget flaky test (#212107)\n\nFixes #198102\n\n##
Summary\n\nThe check that fails is related to
status:All\n[here](https://github.com/elastic/kibana/blob/main/x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts#L191):\n\n```\nexpect(url.includes('status%3Aall')).to.be(true);\n```\n\nIt
seems the status is active from the previous
step:\n\n<img\nsrc=\"https://github.com/user-attachments/assets/8fa33035-d54a-4bfd-9e06-fff696767598\"\nwidth=500
/>\n\n\nThis PR adds a retry to accommodate a delay in changing
URLs.\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"3b1c352df9f4651f21d340133d1b6d91a2199604"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@mistic mistic removed the v9.0.2 label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v9.0.3 v9.1.0

Projects

None yet

Milestone

No milestone

5 participants

@maryam-saeidi @dominiqueclarke @elasticmachine @kibanamachine @mistic