Skip to content

Attempt to fix custom_threshold_preview_chart flaky test #212028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryam-saeidi merged 6 commits into from
Feb 27, 2025
Merged

Attempt to fix custom_threshold_preview_chart flaky test #212028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
024da0f
Attempt to fix flaky test
maryam-saeidi Feb 21, 2025
634eb5d
Fix naming
maryam-saeidi Feb 21, 2025
5557e91
Change getPageObject to getPageObjects
maryam-saeidi Feb 21, 2025
61e1f59
Add log
maryam-saeidi Feb 21, 2025
11db28c
Merge branch 'main' into 209317-flaky-custom-threshold-preview
dominiqueclarke Feb 24, 2025
8365c55
Merge branch 'main' into 209317-flaky-custom-threshold-preview
maryam-saeidi Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/test/functional/services/observability/alerts/rules_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const CUSTOM_THRESHOLD_RULE_TYPE_SELECTOR = 'observability.rules.custom_threshol
export function ObservabilityAlertsRulesProvider({ getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const find = getService('find');
const log = getService('log');

const getManageRulesPageHref = async () => {
const manageRulesPageButton = await testSubjects.find('manageRulesPageButton');
Expand All @@ -21,6 +22,7 @@ export function ObservabilityAlertsRulesProvider({ getService }: FtrProviderCont
const clickCreateRuleButton = async () => {
await testSubjects.existOrFail('createRuleButton');
const createRuleButton = await testSubjects.find('createRuleButton');
log.debug(`clicking on ${await createRuleButton.getAttribute('innerText')}`);
return await createRuleButton.click();
};

Expand Down
5 changes: 3 additions & 2 deletions x-pack/test/observability_functional/apps/observability/pages/alerts/custom_threshold.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
const logger = getService('log');
const retry = getService('retry');
const toasts = getService('toasts');
const PageObjects = getPageObjects(['header']);
const pageObjects = getPageObjects(['header']);

describe('Custom threshold rule', function () {
this.tags('includeFirefox');
Expand Down Expand Up @@ -49,6 +49,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
logger,
});
await observability.alerts.common.navigateToRulesPage();
await pageObjects.header.waitUntilLoadingHasFinished();
});

after(async () => {
Expand All @@ -59,7 +60,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {

it('shows the custom threshold rule in the observability section', async () => {
await observability.alerts.rulesPage.clickCreateRuleButton();
await PageObjects.header.waitUntilLoadingHasFinished();
await pageObjects.header.waitUntilLoadingHasFinished();
await observability.alerts.rulesPage.clickOnObservabilityCategory();
await observability.alerts.rulesPage.clickOnCustomThresholdRule();
});
Expand Down
7 changes: 4 additions & 3 deletions ...bservability_functional/apps/observability/pages/alerts/custom_threshold_preview_chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
import expect from 'expect';
import { FtrProviderContext } from '../../../../ftr_provider_context';

export default ({ getService, getPageObject }: FtrProviderContext) => {
const common = getPageObject('common');
export default ({ getService, getPageObjects }: FtrProviderContext) => {
const esArchiver = getService('esArchiver');
const testSubjects = getService('testSubjects');
const kibanaServer = getService('kibanaServer');
const supertest = getService('supertest');
const find = getService('find');
const logger = getService('log');
const retry = getService('retry');
const pageObjects = getPageObjects(['common', 'header']);

describe('Custom threshold preview chart', () => {
const observability = getService('observability');
Expand All @@ -34,6 +34,7 @@ export default ({ getService, getPageObject }: FtrProviderContext) => {
logger,
});
await observability.alerts.common.navigateToRulesPage();
await pageObjects.header.waitUntilLoadingHasFinished();
});

after(async () => {
Expand All @@ -46,7 +47,7 @@ export default ({ getService, getPageObject }: FtrProviderContext) => {
await observability.alerts.rulesPage.clickCreateRuleButton();
await observability.alerts.rulesPage.clickOnObservabilityCategory();
await observability.alerts.rulesPage.clickOnCustomThresholdRule();
await common.sleep(1000);
await pageObjects.common.sleep(1000);
expect(await find.existsByCssSelector('[data-rendering-count="2"]')).toBe(true);
});

Expand Down