[discover] lazy load actions

[nreese]

Not huge page load savings, but trying to remove deprecated usage of registering actions so we can remove deprecated methods.

[nreese]

moved loadSharingDataHelpers to public/index.ts to avoid loading getSortForEmbeddable in page load bundle.

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

@elasticmachine merge upstream

[nreese]

/ci

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: aec6e89

Failed CI Steps

• FTR Configs #102

Test Failures

• [job] [logs] FTR Configs #102 / Stateful Observability - Deployment-agnostic API integration tests SyntheticsAPITests getSyntheticsMonitors get many monitors without params

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
discoverEnhanced	33	23	-10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	917.9KB	921.0KB	+3.1KB
discoverEnhanced	0.0B	4.7KB	+4.7KB
total			+7.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
discoverEnhanced	2	0	-2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	44.2KB	41.0KB	-3.2KB
discoverEnhanced	7.5KB	5.1KB	-2.4KB
total			-5.6KB

Unknown metric groups

API count

id	before	after	diff
discoverEnhanced	35	23	-12

async chunk count

id	before	after	diff
discoverEnhanced	0	1	+1

References to deprecated APIs

id	before	after	diff
discover	11	10	-1
discoverEnhanced	2	0	-2
total			-3

History

• 💔 Build #281279 failed 33ea431
• 💔 Build #281257 failed 68a9eef
• 💔 Build #278206 failed 9208e61
• 💔 Build #278198 failed 9d79161

[davismcphee]

Thanks for working on this! Looks great overall, although I think there's some overlap with another PR I opened to fully optimize the Discover page load bundle: #208298.

But there are still some improvements here to discoverEnhanced that aren't covered in my PR. Would you mind if we hold off on this one for now until mine is merged, and rebase this after? Would be great to still get the improvements here that aren't addressed in the other PR.

[davismcphee]

@nreese Just a quick heads up that #208298 has now been merged.