Skip to content

[9.0] SKA: Unify kbn-management folders + storybook config (#211564) #211688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsoldevila merged 1 commit into from
Feb 19, 2025
Merged

[9.0] SKA: Unify kbn-management folders + storybook config (#211564) #211688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ packages/kbn-lint-packages-cli @elastic/kibana-operations
packages/kbn-lint-ts-projects-cli @elastic/kibana-operations
packages/kbn-managed-vscode-config @elastic/kibana-operations
packages/kbn-managed-vscode-config-cli @elastic/kibana-operations
packages/kbn-management/storybook/config @elastic/kibana-management
packages/kbn-manifest @elastic/kibana-core
packages/kbn-mock-idp-plugin @elastic/kibana-security
packages/kbn-mock-idp-utils @elastic/kibana-security
Expand Down Expand Up @@ -367,9 +366,6 @@ src/platform/packages/private/kbn-item-buffer @elastic/appex-sharedux
src/platform/packages/private/kbn-language-documentation @elastic/kibana-esql
src/platform/packages/private/kbn-lens-formula-docs @elastic/kibana-visualizations
src/platform/packages/private/kbn-managed-content-badge @elastic/kibana-visualizations
src/platform/packages/private/kbn-management/settings/application @elastic/kibana-management
src/platform/packages/private/kbn-management/settings/components/field_category @elastic/kibana-management
src/platform/packages/private/kbn-management/settings/components/form @elastic/kibana-management
src/platform/packages/private/kbn-mapbox-gl @elastic/kibana-presentation
src/platform/packages/private/kbn-panel-loader @elastic/kibana-presentation
src/platform/packages/private/kbn-react-mute-legacy-root-warning @elastic/appex-sharedux
Expand Down Expand Up @@ -482,13 +478,17 @@ src/platform/packages/shared/kbn-logging @elastic/kibana-core
src/platform/packages/shared/kbn-logging-mocks @elastic/kibana-core
src/platform/packages/shared/kbn-management/cards_navigation @elastic/kibana-management
src/platform/packages/shared/kbn-management/delete_managed_assets_callout @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/application @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/field_category @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/field_input @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/field_row @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/components/form @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/field_definition @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/section_registry @elastic/appex-sharedux @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/setting_ids @elastic/appex-sharedux @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/types @elastic/kibana-management
src/platform/packages/shared/kbn-management/settings/utilities @elastic/kibana-management
src/platform/packages/shared/kbn-management/storybook/config @elastic/kibana-management
src/platform/packages/shared/kbn-monaco @elastic/appex-sharedux
src/platform/packages/shared/kbn-object-utils @elastic/kibana-core
src/platform/packages/shared/kbn-object-versioning @elastic/appex-sharedux
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,11 +635,11 @@
"@kbn/managed-content-badge": "link:src/platform/packages/private/kbn-managed-content-badge",
"@kbn/management-cards-navigation": "link:src/platform/packages/shared/kbn-management/cards_navigation",
"@kbn/management-plugin": "link:src/platform/plugins/shared/management",
"@kbn/management-settings-application": "link:src/platform/packages/private/kbn-management/settings/application",
"@kbn/management-settings-components-field-category": "link:src/platform/packages/private/kbn-management/settings/components/field_category",
"@kbn/management-settings-application": "link:src/platform/packages/shared/kbn-management/settings/application",
"@kbn/management-settings-components-field-category": "link:src/platform/packages/shared/kbn-management/settings/components/field_category",
"@kbn/management-settings-components-field-input": "link:src/platform/packages/shared/kbn-management/settings/components/field_input",
"@kbn/management-settings-components-field-row": "link:src/platform/packages/shared/kbn-management/settings/components/field_row",
"@kbn/management-settings-components-form": "link:src/platform/packages/private/kbn-management/settings/components/form",
"@kbn/management-settings-components-form": "link:src/platform/packages/shared/kbn-management/settings/components/form",
"@kbn/management-settings-field-definition": "link:src/platform/packages/shared/kbn-management/settings/field_definition",
"@kbn/management-settings-ids": "link:src/platform/packages/shared/kbn-management/settings/setting_ids",
"@kbn/management-settings-section-registry": "link:src/platform/packages/shared/kbn-management/settings/section_registry",
Expand Down Expand Up @@ -1462,7 +1462,7 @@
"@kbn/lint-ts-projects-cli": "link:packages/kbn-lint-ts-projects-cli",
"@kbn/managed-vscode-config": "link:packages/kbn-managed-vscode-config",
"@kbn/managed-vscode-config-cli": "link:packages/kbn-managed-vscode-config-cli",
"@kbn/management-storybook-config": "link:packages/kbn-management/storybook/config",
"@kbn/management-storybook-config": "link:src/platform/packages/shared/kbn-management/storybook/config",
"@kbn/manifest": "link:packages/kbn-manifest",
"@kbn/mock-idp-plugin": "link:packages/kbn-mock-idp-plugin",
"@kbn/mock-idp-utils": "link:packages/kbn-mock-idp-utils",
Expand Down
18 changes: 0 additions & 18 deletions packages/kbn-management/settings/jest.config.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/dev/storybook/aliases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const storybookAliases = {
kibana_react: 'src/platform/plugins/shared/kibana_react/.storybook',
lists: 'x-pack/solutions/security/plugins/lists/.storybook',
logs_explorer: 'x-pack/solutions/observability/plugins/logs_explorer/.storybook',
management: 'packages/kbn-management/storybook/config',
management: 'src/platform/packages/shared/kbn-management/storybook/config',
observability: 'x-pack/solutions/observability/plugins/observability/.storybook',
observability_ai_assistant:
'x-pack/platform/plugins/shared/observability_ai_assistant/.storybook',
Expand Down
14 changes: 0 additions & 14 deletions src/platform/packages/private/kbn-management/jest.config.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/kbn-management/settings/README.mdx → ...shared/kbn-management/settings/README.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ These packages comprise the Management Advanced Settings application. The sourc

In the interest of time and compatibility, we've opted to use the pattern from the original components in `advancedSettings`. We plan to revisit the state management and prop-drilling when `advancedSettings` is refactored with these components.

This is being tracked with https://github.com/elastic/kibana/issues/166579
This is being tracked with https://github.com/elastic/kibana/issues/166579
0 ...management/settings/application/README.md → ...management/settings/application/README.md
View file
Open in desktop
File renamed without changes.
0 ...n/__snapshots__/query_input.test.tsx.snap → ...n/__snapshots__/query_input.test.tsx.snap
View file
Open in desktop
File renamed without changes.
0 ...ation/__stories__/application.stories.tsx → ...ation/__stories__/application.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...ion/__stories__/use_application_story.tsx → ...ion/__stories__/use_application_story.tsx
View file
Open in desktop
File renamed without changes.
0 ...settings/application/application.test.tsx → ...settings/application/application.test.tsx
View file
Open in desktop
File renamed without changes.
0 ...ment/settings/application/application.tsx → ...ment/settings/application/application.tsx
View file
Open in desktop
File renamed without changes.
0 ...ment/settings/application/empty_state.tsx → ...ment/settings/application/empty_state.tsx
View file
Open in desktop
File renamed without changes.
0 ...ement/settings/application/hooks/index.ts → ...ement/settings/application/hooks/index.ts
View file
Open in desktop
File renamed without changes.
0 .../settings/application/hooks/use_fields.ts → .../settings/application/hooks/use_fields.ts
View file
Open in desktop
File renamed without changes.
0 ...ngs/application/hooks/use_scope_fields.ts → ...ngs/application/hooks/use_scope_fields.ts
View file
Open in desktop
File renamed without changes.
0 ...ettings/application/hooks/use_settings.ts → ...ettings/application/hooks/use_settings.ts
View file
Open in desktop
File renamed without changes.
0 ...gement/settings/application/i18n_texts.ts → ...gement/settings/application/i18n_texts.ts
View file
Open in desktop
File renamed without changes.
0 ...management/settings/application/index.tsx → ...management/settings/application/index.tsx
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...agement/settings/application/kibana.jsonc → ...agement/settings/application/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
"@elastic/kibana-management"
],
"group": "platform",
"visibility": "private"
}
"visibility": "shared"
}
0 ...nt/settings/application/mocks/context.tsx → ...nt/settings/application/mocks/context.tsx
View file
Open in desktop
File renamed without changes.
0 ...ement/settings/application/mocks/index.ts → ...ement/settings/application/mocks/index.ts
View file
Open in desktop
File renamed without changes.
0 ...agement/settings/application/package.json → ...agement/settings/application/package.json
View file
Open in desktop
File renamed without changes.
0 ...settings/application/query_input.test.tsx → ...settings/application/query_input.test.tsx
View file
Open in desktop
File renamed without changes.
0 ...ment/settings/application/query_input.tsx → ...ment/settings/application/query_input.tsx
View file
Open in desktop
File renamed without changes.
0 ...t/settings/application/read_only_badge.ts → ...t/settings/application/read_only_badge.ts
View file
Open in desktop
File renamed without changes.
0 ...agement/settings/application/services.tsx → ...agement/settings/application/services.tsx
View file
Open in desktop
File renamed without changes.
0 ...n-management/settings/application/tab.tsx → ...n-management/settings/application/tab.tsx
View file
Open in desktop
File renamed without changes.
0 ...gement/settings/application/tsconfig.json → ...gement/settings/application/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 ...ings/components/field_category/README.mdx → ...ings/components/field_category/README.mdx
View file
Open in desktop
File renamed without changes.
0 ...tegory/__stories__/categories.stories.tsx → ...tegory/__stories__/categories.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...category/__stories__/category.stories.tsx → ...category/__stories__/category.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...tegory/__stories__/use_category_story.tsx → ...tegory/__stories__/use_category_story.tsx
View file
Open in desktop
File renamed without changes.
0 .../components/field_category/categories.tsx → .../components/field_category/categories.tsx
View file
Open in desktop
File renamed without changes.
0 ...gs/components/field_category/category.tsx → ...gs/components/field_category/category.tsx
View file
Open in desktop
File renamed without changes.
0 ...nents/field_category/clear_query_link.tsx → ...nents/field_category/clear_query_link.tsx
View file
Open in desktop
File renamed without changes.
0 ...ttings/components/field_category/index.ts → ...ttings/components/field_category/index.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../components/field_category/jest.config.js → .../components/field_category/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ module.exports = {
preset: '@kbn/test',
rootDir: '../../../../../../../..',
roots: [
'<rootDir>/src/platform/packages/private/kbn-management/settings/components/field_category',
'<rootDir>/src/platform/packages/shared/kbn-management/settings/components/field_category',
],
};
4 changes: 2 additions & 2 deletions ...gs/components/field_category/kibana.jsonc → ...gs/components/field_category/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
"@elastic/kibana-management"
],
"group": "platform",
"visibility": "private"
}
"visibility": "shared"
}
0 ...gs/components/field_category/package.json → ...gs/components/field_category/package.json
View file
Open in desktop
File renamed without changes.
0 ...gs/components/field_category/services.tsx → ...gs/components/field_category/services.tsx
View file
Open in desktop
File renamed without changes.
0 ...s/components/field_category/tsconfig.json → ...s/components/field_category/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 ...ttings/components/field_category/types.ts → ...ttings/components/field_category/types.ts
View file
Open in desktop
File renamed without changes.
0 ...ement/settings/components/form/README.mdx → ...ement/settings/components/form/README.mdx
View file
Open in desktop
File renamed without changes.
0 ...nents/form/bottom_bar/bottom_bar.test.tsx → ...nents/form/bottom_bar/bottom_bar.test.tsx
View file
Open in desktop
File renamed without changes.
0 ...components/form/bottom_bar/bottom_bar.tsx → ...components/form/bottom_bar/bottom_bar.tsx
View file
Open in desktop
File renamed without changes.
0 ...ings/components/form/bottom_bar/index.tsx → ...ings/components/form/bottom_bar/index.tsx
View file
Open in desktop
File renamed without changes.
0 ...ponents/form/bottom_bar/unsaved_count.tsx → ...ponents/form/bottom_bar/unsaved_count.tsx
View file
Open in desktop
File renamed without changes.
0 ...t/settings/components/form/form.styles.ts → ...t/settings/components/form/form.styles.ts
View file
Open in desktop
File renamed without changes.
0 ...nt/settings/components/form/form.test.tsx → ...nt/settings/components/form/form.test.tsx
View file
Open in desktop
File renamed without changes.
0 ...agement/settings/components/form/form.tsx → ...agement/settings/components/form/form.tsx
View file
Open in desktop
File renamed without changes.
0 ...agement/settings/components/form/index.ts → ...agement/settings/components/form/index.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ent/settings/components/form/kibana.jsonc → ...ent/settings/components/form/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
"@elastic/kibana-management"
],
"group": "platform",
"visibility": "private"
}
"visibility": "shared"
}
0 ...ettings/components/form/mocks/context.tsx → ...ettings/components/form/mocks/context.tsx
View file
Open in desktop
File renamed without changes.
0 ...t/settings/components/form/mocks/index.ts → ...t/settings/components/form/mocks/index.ts
View file
Open in desktop
File renamed without changes.
0 .../components/form/mocks/settings_client.ts → .../components/form/mocks/settings_client.ts
View file
Open in desktop
File renamed without changes.
0 ...ent/settings/components/form/package.json → ...ent/settings/components/form/package.json
View file
Open in desktop
File renamed without changes.
0 ...ngs/components/form/reload_page_toast.tsx → ...ngs/components/form/reload_page_toast.tsx
View file
Open in desktop
File renamed without changes.
0 ...ent/settings/components/form/services.tsx → ...ent/settings/components/form/services.tsx
View file
Open in desktop
File renamed without changes.
0 ...omponents/form/storybook/form.stories.tsx → ...omponents/form/storybook/form.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...nt/settings/components/form/tsconfig.json → ...nt/settings/components/form/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 ...agement/settings/components/form/types.ts → ...agement/settings/components/form/types.ts
View file
Open in desktop
File renamed without changes.
0 ...ment/settings/components/form/use_save.ts → ...ment/settings/components/form/use_save.ts
View file
Open in desktop
File renamed without changes.
0 ...bn-management/storybook/config/README.mdx → ...bn-management/storybook/config/README.mdx
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion ...-management/storybook/config/constants.ts → ...-management/storybook/config/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
export const TITLE = 'kbn-management storybook';

/** The remote URL of the root from which Storybook loads stories for kbn-management. */
export const URL = 'https://github.com/elastic/kibana/tree/main/packages/kbn-management';
export const URL =
'https://github.com/elastic/kibana/tree/main/src/platform/packages/shared/kbn-management';
0 .../kbn-management/storybook/config/index.ts → .../kbn-management/storybook/config/index.ts
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions ...-management/storybook/config/kibana.jsonc → ...-management/storybook/config/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@
"type": "shared-common",
"id": "@kbn/management-storybook-config",
"owner": "@elastic/kibana-management",
"group": "platform",
"visibility": "shared",
"devOnly": true
}
4 changes: 1 addition & 3 deletions ...s/kbn-management/storybook/config/main.ts → ...d/kbn-management/storybook/config/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ import { defaultConfig } from '@kbn/storybook';

module.exports = {
...defaultConfig,
stories: [
'../../../../src/platform/packages/(private|shared)/kbn-management/**/*.stories.+(tsx|mdx)',
],
stories: ['../../**/*.stories.+(tsx|mdx)'],
reactOptions: {
strictMode: true,
},
Expand Down
0 ...bn-management/storybook/config/manager.ts → ...bn-management/storybook/config/manager.ts
View file
Open in desktop
File renamed without changes.
0 ...-management/storybook/config/package.json → ...-management/storybook/config/package.json
View file
Open in desktop
File renamed without changes.
0 ...bn-management/storybook/config/preview.ts → ...bn-management/storybook/config/preview.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...management/storybook/config/tsconfig.json → ...management/storybook/config/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../../tsconfig.base.json",
"extends": "../../../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
16 changes: 8 additions & 8 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,16 +1204,16 @@
"@kbn/management-cards-navigation/*": ["src/platform/packages/shared/kbn-management/cards_navigation/*"],
"@kbn/management-plugin": ["src/platform/plugins/shared/management"],
"@kbn/management-plugin/*": ["src/platform/plugins/shared/management/*"],
"@kbn/management-settings-application": ["src/platform/packages/private/kbn-management/settings/application"],
"@kbn/management-settings-application/*": ["src/platform/packages/private/kbn-management/settings/application/*"],
"@kbn/management-settings-components-field-category": ["src/platform/packages/private/kbn-management/settings/components/field_category"],
"@kbn/management-settings-components-field-category/*": ["src/platform/packages/private/kbn-management/settings/components/field_category/*"],
"@kbn/management-settings-application": ["src/platform/packages/shared/kbn-management/settings/application"],
"@kbn/management-settings-application/*": ["src/platform/packages/shared/kbn-management/settings/application/*"],
"@kbn/management-settings-components-field-category": ["src/platform/packages/shared/kbn-management/settings/components/field_category"],
"@kbn/management-settings-components-field-category/*": ["src/platform/packages/shared/kbn-management/settings/components/field_category/*"],
"@kbn/management-settings-components-field-input": ["src/platform/packages/shared/kbn-management/settings/components/field_input"],
"@kbn/management-settings-components-field-input/*": ["src/platform/packages/shared/kbn-management/settings/components/field_input/*"],
"@kbn/management-settings-components-field-row": ["src/platform/packages/shared/kbn-management/settings/components/field_row"],
"@kbn/management-settings-components-field-row/*": ["src/platform/packages/shared/kbn-management/settings/components/field_row/*"],
"@kbn/management-settings-components-form": ["src/platform/packages/private/kbn-management/settings/components/form"],
"@kbn/management-settings-components-form/*": ["src/platform/packages/private/kbn-management/settings/components/form/*"],
"@kbn/management-settings-components-form": ["src/platform/packages/shared/kbn-management/settings/components/form"],
"@kbn/management-settings-components-form/*": ["src/platform/packages/shared/kbn-management/settings/components/form/*"],
"@kbn/management-settings-field-definition": ["src/platform/packages/shared/kbn-management/settings/field_definition"],
"@kbn/management-settings-field-definition/*": ["src/platform/packages/shared/kbn-management/settings/field_definition/*"],
"@kbn/management-settings-ids": ["src/platform/packages/shared/kbn-management/settings/setting_ids"],
Expand All @@ -1224,8 +1224,8 @@
"@kbn/management-settings-types/*": ["src/platform/packages/shared/kbn-management/settings/types/*"],
"@kbn/management-settings-utilities": ["src/platform/packages/shared/kbn-management/settings/utilities"],
"@kbn/management-settings-utilities/*": ["src/platform/packages/shared/kbn-management/settings/utilities/*"],
"@kbn/management-storybook-config": ["packages/kbn-management/storybook/config"],
"@kbn/management-storybook-config/*": ["packages/kbn-management/storybook/config/*"],
"@kbn/management-storybook-config": ["src/platform/packages/shared/kbn-management/storybook/config"],
"@kbn/management-storybook-config/*": ["src/platform/packages/shared/kbn-management/storybook/config/*"],
"@kbn/management-test-plugin": ["test/plugin_functional/plugins/management_test_plugin"],
"@kbn/management-test-plugin/*": ["test/plugin_functional/plugins/management_test_plugin/*"],
"@kbn/manifest": ["packages/kbn-manifest"],
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6277,11 +6277,11 @@
version "0.0.0"
uid ""

"@kbn/management-settings-application@link:src/platform/packages/private/kbn-management/settings/application":
"@kbn/management-settings-application@link:src/platform/packages/shared/kbn-management/settings/application":
version "0.0.0"
uid ""

"@kbn/management-settings-components-field-category@link:src/platform/packages/private/kbn-management/settings/components/field_category":
"@kbn/management-settings-components-field-category@link:src/platform/packages/shared/kbn-management/settings/components/field_category":
version "0.0.0"
uid ""

Expand All @@ -6293,7 +6293,7 @@
version "0.0.0"
uid ""

"@kbn/management-settings-components-form@link:src/platform/packages/private/kbn-management/settings/components/form":
"@kbn/management-settings-components-form@link:src/platform/packages/shared/kbn-management/settings/components/form":
version "0.0.0"
uid ""

Expand All @@ -6317,7 +6317,7 @@
version "0.0.0"
uid ""

"@kbn/management-storybook-config@link:packages/kbn-management/storybook/config":
"@kbn/management-storybook-config@link:src/platform/packages/shared/kbn-management/storybook/config":
version "0.0.0"
uid ""

Expand Down