-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Share modal re-architecture #211665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Share modal re-architecture #211665
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ce4296c
save progress
eokoneyo 0fa9b6e
idea validation
eokoneyo c3e6e2c
start levergaing new share options registry implementation
eokoneyo 41a5ecb
start to converge into new implementation across usages of the share …
eokoneyo b112b9d
slight adjustments
eokoneyo 109ad0b
use descriptive identifier for value that denotes publicAPI and embed…
eokoneyo 11f8dc5
fix types
eokoneyo 2bc6979
even more changes to toggleShareMenu signature
eokoneyo 63fdffb
modify share registry backing data name
eokoneyo 31f25dd
add implementation to back legacy share implementations
eokoneyo a861f1a
fix types
eokoneyo b6718da
type useShareTabsContext and tab contents correctly
eokoneyo b853b13
start on fixing tests
eokoneyo 5768b46
start on aligning existing share integrations to match share plugin e…
eokoneyo 1541b8f
more test fixes
eokoneyo 5a82f71
clean up config provided by the reporting export share integration
eokoneyo 312f19f
support async functions for delegatedShareUrlHandler
eokoneyo b533b70
remove unused config values passed from the export type
eokoneyo 5256a01
fix errors from lint and type checks
eokoneyo b5883f5
actually select the export type for lens csv downloader helper
eokoneyo 5bf0694
make adjustments to evaluate share url lazily in lens
eokoneyo 8c853ce
fix types for render points
eokoneyo 91c7dae
Merge branch 'main' into feat/share-rearchitecture
elasticmachine 2c0e85c
Merge branch 'main' into feat/share-rearchitecture
elasticmachine 0442b8d
attend to PR comment
eokoneyo 021e2ec
Merge branch 'main' into feat/share-rearchitecture
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional to change the parm for
getSearchModeParams()fromfalsepreviously, totruein this PR? It looks like it changes theabsoluteTimeparam ofgetSearchSource()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was... however I'd be reverting to the previous implementation because there's another body of work that actually takes care of providing the user a choice on wether they'd like to use absolute or relative time when choosing to share, instead of forcing it.