Skip to content

[8.17] Backport rowHeightOption: auto EuiDataGrid fix#211613

Closed
weronikaolejniczak wants to merge 3 commits intoelastic:8.17from
weronikaolejniczak:chore/backport-eui-0
Closed

[8.17] Backport rowHeightOption: auto EuiDataGrid fix#211613
weronikaolejniczak wants to merge 3 commits intoelastic:8.17from
weronikaolejniczak:chore/backport-eui-0

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Feb 18, 2025

Summary

Fix for elastic/eui#8245

Backporting af189da to 8.17 Kibana version. It was introduced on elastic/eui#8251.

The npm backport release: https://www.npmjs.com/package/@elastic/eui/v/97.3.1-backport.0

Checklist

The issue being backported, elastic/eui#8245, is intermittent. You cannot consistently reproduce it on OSX, apparently it's reproducible on Windows. I'd appreciate a manual test from the reviewers 🙏🏻

The steps to reproduce in 8.17 are:

  1. Go to Security > Alerts.
  2. In the data grid, set the view from "Grid view" to "Event rendered view".
  3. Choose the settings icon, in the picker choose "Auto fit" in Row height.

The data grid's height changes to 0. It's reproducible on first load.

@weronikaolejniczak weronikaolejniczak requested review from a team as code owners February 18, 2025 16:35
@weronikaolejniczak weronikaolejniczak requested a review from a team February 18, 2025 16:35
@weronikaolejniczak weronikaolejniczak requested review from a team as code owners February 18, 2025 16:35
@weronikaolejniczak weronikaolejniczak changed the base branch from main to 8.17 February 18, 2025 16:35
@weronikaolejniczak weronikaolejniczak added the backport This PR is a backport of another PR label Feb 18, 2025
@weronikaolejniczak weronikaolejniczak changed the title [8.17] Backport EuiDataGrid fix [8.17] Backport rowHeightOption: auto EuiDataGrid fix Feb 18, 2025
@weronikaolejniczak
Copy link
Contributor Author

@elasticmachine merge upstream

@github-actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@weronikaolejniczak weronikaolejniczak requested review from kqualters-elastic and logeekal and removed request for a team, dplumlee and kibanamachine February 19, 2025 13:18
@weronikaolejniczak
Copy link
Contributor Author

weronikaolejniczak commented Feb 19, 2025

All the above-mentioned reviewers were added automatically ☝🏻 but it's more than expected, we only need @elastic/kibana-operations approve.

@logeekal @kqualters-elastic I'd appreciate your QA, mates 🙏🏻 it seems you are the most well-informed regarding this issue. If I can help in any way, please let me know!

@logeekal
Copy link
Contributor

logeekal commented Feb 19, 2025

@logeekal @kqualters-elastic I'd appreciate your QA, mates 🙏🏻 it seems you are the most well-informed regarding this issue. If I can help in any way, please let me know!

Thanks @weronikaolejniczak for the tag. I will desk test it later today and reply.

@weronikaolejniczak weronikaolejniczak removed the request for review from a team February 19, 2025 13:25
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible issue with the fix this is backporting, blocking this until we talk through it

@weronikaolejniczak
Copy link
Contributor Author

@kqualters-elastic I will update the PR with the suggestion from @jbudz just in case we proceed with the release.

Copy link
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I did some Desk Testing and it looks like error still exists. The error surfaces when the height of the complete table and row are both auto.
In security Solution, whenever the number of items in Alert table is below 20, we set the table height as auto which results in this wierd error.

See below demo.

Screen.Recording.2025-02-20.at.11.03.59.mov

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.8MB 5.8MB +12.0B

History

@weronikaolejniczak
Copy link
Contributor Author

Closing the backport PRs due to the above-mentioned issues. Going back to the drawing board with this issue.

@weronikaolejniczak weronikaolejniczak deleted the chore/backport-eui-0 branch February 10, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants