Skip to content

Clear gap filters after unmounting component#211588

Merged
nkhristinin merged 3 commits intoelastic:mainfrom
nkhristinin:clear-filter
Feb 21, 2025
Merged

Clear gap filters after unmounting component#211588
nkhristinin merged 3 commits intoelastic:mainfrom
nkhristinin:clear-filter

Conversation

@nkhristinin
Copy link
Copy Markdown
Contributor

@nkhristinin nkhristinin commented Feb 18, 2025 •
edited by kibanamachine
Loading

When we move out monitoring tab we reset filters to show only rule with gaps

Screen.Recording.2025-02-18.at.15.50.40.mov

@nkhristinin nkhristinin requested a review from a team as a code owner February 18, 2025 14:51
@nkhristinin nkhristinin requested a review from rylnd February 18, 2025 14:52
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor backport:version Backport to applied version labels v8.18.0 labels Feb 18, 2025
@nkhristinin
Copy link
Copy Markdown
Contributor Author

nkhristinin commented Feb 19, 2025

@elasticmachine merge upstream

@nkhristinin
Copy link
Copy Markdown
Contributor Author

nkhristinin commented Feb 19, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #84 / discover/group4 adhoc data views search results should be different after data view update

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.9MB 8.9MB +85.0B

History

rylnd
rylnd approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkhristinin nkhristinin merged commit 24d948d into elastic:main Feb 21, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 21, 2025

Starting backport for target branches: 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13453799588

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2025
@nkhristinin @elasticmachine
Clear gap filters after unmounting component (elastic#211588)
d202e36 
## When we move out monitoring tab we reset filters to show only rule
with gaps

https://github.com/user-attachments/assets/d86b248e-62e1-41c7-9873-8140a8d86b81

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 24d948d)
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2025
@nkhristinin @elasticmachine
Clear gap filters after unmounting component (elastic#211588)
a36c286 
## When we move out monitoring tab we reset filters to show only rule
with gaps

https://github.com/user-attachments/assets/d86b248e-62e1-41c7-9873-8140a8d86b81

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 24d948d)
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 21, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.18
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Feb 21, 2025
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 24, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

6 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 25, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 26, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 27, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 28, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 3, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 4, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 1, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

16 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 2, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 3, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 4, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 8, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 9, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 10, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 11, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 14, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 15, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 16, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 17, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 18, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 21, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 24, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 25, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 28, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 29, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 30, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

@nkhristinin nkhristinin removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 30, 2025
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 1, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 1, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 2, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nkhristinin

kibanamachine added a commit that referenced this pull request May 7, 2025
@kibanamachine @nkhristinin @elasticmachine
[9.0] Clear gap filters after unmounting component (#211588) (#212021)
002ba71 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Clear gap filters after unmounting component
(#211588)](#211588)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T09:22:57Z","message":"Clear
gap filters after unmounting component (#211588)\n\n## When we move out
monitoring tab we reset filters to show only rule\nwith
gaps\n\n\n\n\nhttps://github.com/user-attachments/assets/d86b248e-62e1-41c7-9873-8140a8d86b81\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"24d948db43cd55e4a25836ba3d227aaffbd08891","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:version","v8.18.0","v9.1.0"],"title":"Clear
gap filters after unmounting
component","number":211588,"url":"https://github.com/elastic/kibana/pull/211588","mergeCommit":{"message":"Clear
gap filters after unmounting component (#211588)\n\n## When we move out
monitoring tab we reset filters to show only rule\nwith
gaps\n\n\n\n\nhttps://github.com/user-attachments/assets/d86b248e-62e1-41c7-9873-8140a8d86b81\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"24d948db43cd55e4a25836ba3d227aaffbd08891"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211588","number":211588,"mergeCommit":{"message":"Clear
gap filters after unmounting component (#211588)\n\n## When we move out
monitoring tab we reset filters to show only rule\nwith
gaps\n\n\n\n\nhttps://github.com/user-attachments/assets/d86b248e-62e1-41c7-9873-8140a8d86b81\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"24d948db43cd55e4a25836ba3d227aaffbd08891"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine added v9.0.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0 v9.0.2 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nkhristinin @elasticmachine @kibanamachine @rylnd