SKA: Unify kbn-management folders + storybook config#211564
Merged
gsoldevila merged 2 commits intoelastic:mainfrom Feb 19, 2025
Merged
SKA: Unify kbn-management folders + storybook config#211564gsoldevila merged 2 commits intoelastic:mainfrom
kbn-management folders + storybook config#211564gsoldevila merged 2 commits intoelastic:mainfrom
Conversation
gsoldevila
added
Team:Kibana Management
delanni
approved these changes
Feb 18, 2025
ElenaStoeva
reviewed
Feb 18, 2025
Contributor
There was a problem hiding this comment.
Kibana Management changes lgtm, but I'm deferring approval to @mattkime since he primarily worked on moving the team's modules for the Sustainable Kibana Architecture project and I'm not familiar with the reasoning behind why some of the packages were moved to the private directory while others were placed in shared.
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
Member
Author
I can answer this one. The visibility property applies to all packages in the
They were automatically categorised as private because they were not being imported / used from any solution. |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13408047231 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Feb 19, 2025
## Summary As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for `kbn-management` modules, that are spread across: ``` - packages/kbn-management (storybook config) - src/platform/packages/private/kbn-management - src/platform/packages/shared/kbn-management ``` The goal of this PR is to unify them back under `src/platform/packages/shared/kbn-management`. In this scenario, I believe the simplification is worth the trade off. CC @elastic/kibana-management WDYT? Co-authored-by: Matthew Kime <matt@mattki.me> (cherry picked from commit b2b3fa9) # Conflicts: # src/dev/storybook/aliases.ts
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Feb 19, 2025
## Summary As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for `kbn-management` modules, that are spread across: ``` - packages/kbn-management (storybook config) - src/platform/packages/private/kbn-management - src/platform/packages/shared/kbn-management ``` The goal of this PR is to unify them back under `src/platform/packages/shared/kbn-management`. In this scenario, I believe the simplification is worth the trade off. CC @elastic/kibana-management WDYT? Co-authored-by: Matthew Kime <matt@mattki.me> (cherry picked from commit b2b3fa9) # Conflicts: # .github/CODEOWNERS # src/dev/storybook/aliases.ts
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Feb 19, 2025
## Summary As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for `kbn-management` modules, that are spread across: ``` - packages/kbn-management (storybook config) - src/platform/packages/private/kbn-management - src/platform/packages/shared/kbn-management ``` The goal of this PR is to unify them back under `src/platform/packages/shared/kbn-management`. In this scenario, I believe the simplification is worth the trade off. CC @elastic/kibana-management WDYT? Co-authored-by: Matthew Kime <matt@mattki.me> (cherry picked from commit b2b3fa9) # Conflicts: # .github/CODEOWNERS # src/dev/storybook/aliases.ts
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
that referenced
this pull request
Feb 19, 2025
#211688) # Backport This will backport the following commits from `main` to `9.0`: - [SKA: Unify `kbn-management` folders + storybook config (#211564)](#211564) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA: Unify `kbn-management` folders + storybook config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
gsoldevila
added a commit
that referenced
this pull request
Feb 19, 2025
#211690) # Backport This will backport the following commits from `main` to `8.x`: - [SKA: Unify `kbn-management` folders + storybook config (#211564)](#211564) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA: Unify `kbn-management` folders + storybook config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
gsoldevila
added a commit
that referenced
this pull request
Feb 19, 2025
… (#211691) # Backport This will backport the following commits from `main` to `8.18`: - [SKA: Unify `kbn-management` folders + storybook config (#211564)](#211564) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA: Unify `kbn-management` folders + storybook config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA: Unify `kbn-management` folders + storybook config (#211564)\n\n## Summary\r\n\r\nAs part of the SKA, some groups of modules have been broken-down and\r\nrelocated in different folders, negatively impacting DX. This is the\r\ncase for `kbn-management` modules, that are spread across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n- src/platform/packages/private/kbn-management\r\n- src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of this PR is to unify them back under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this scenario, I believe the simplification is worth the trade off.\r\n\r\nCC @elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime <matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for `kbn-management` modules, that are spread across: ``` - packages/kbn-management (storybook config) - src/platform/packages/private/kbn-management - src/platform/packages/shared/kbn-management ``` The goal of this PR is to unify them back under `src/platform/packages/shared/kbn-management`. In this scenario, I believe the simplification is worth the trade off. CC @elastic/kibana-management WDYT? Co-authored-by: Matthew Kime <matt@mattki.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for
kbn-managementmodules, that are spread across:The goal of this PR is to unify them back under
src/platform/packages/shared/kbn-management.In this scenario, I believe the simplification is worth the trade off.
CC @elastic/kibana-management WDYT?