Skip to content

[8.x] SKA: Fix kebab-case issues in obs-ux-logs packages (#211347)#211383

Merged
gsoldevila merged 1 commit intoelastic:8.xfrom
gsoldevila:backport/8.x/pr-211347
Feb 17, 2025
Merged

[8.x] SKA: Fix kebab-case issues in obs-ux-logs packages (#211347)#211383
gsoldevila merged 1 commit intoelastic:8.xfrom
gsoldevila:backport/8.x/pr-211347

Conversation

@gsoldevila
Copy link
Copy Markdown
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/logs-overview` | `x-pack/platform/packages/shared/logs-overview`
|

<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/logs-overview/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/platform/packages/shared/logs-overview/jest.config.js:10
x-pack/platform/packages/shared/logs-overview/tsconfig.json:2
```

</details>

(cherry picked from commit 0ecbbd5)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	tsconfig.base.json
#	yarn.lock
@gsoldevila gsoldevila added the backport This PR is a backport of another PR label Feb 17, 2025
@gsoldevila gsoldevila enabled auto-merge (squash) February 17, 2025 09:33
@gsoldevila gsoldevila merged commit 361ca2f into elastic:8.x Feb 17, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logsShared 218.9KB 218.9KB -1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logsShared 139.9KB 139.9KB -3.0B

gsoldevila added a commit that referenced this pull request Feb 19, 2025
…211701)

# Backport

This will backport the following commits from `main` to `8.18`:
- [SKA: Fix kebab-case issues in obs-ux-logs packages
(#211347)](#211347)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-17T08:08:38Z","message":"SKA:
Fix kebab-case issues in obs-ux-logs packages (#211347)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/logs-overview` |
`x-pack/platform/packages/shared/logs-overview`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/logs-overview/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/logs-overview/jest.config.js:10\r\nx-pack/platform/packages/shared/logs-overview/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"0ecbbd52becb2d48150c837149d54125ddd5c6e3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-logs","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Fix kebab-case issues in obs-ux-logs
packages","number":211347,"url":"https://github.com/elastic/kibana/pull/211347","mergeCommit":{"message":"SKA:
Fix kebab-case issues in obs-ux-logs packages (#211347)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/logs-overview` |
`x-pack/platform/packages/shared/logs-overview`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/logs-overview/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/logs-overview/jest.config.js:10\r\nx-pack/platform/packages/shared/logs-overview/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"0ecbbd52becb2d48150c837149d54125ddd5c6e3"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211382","number":211382,"state":"MERGED","mergeCommit":{"sha":"b2618cf19d288c483e00ed73917d1cd821592ee0","message":"[9.0]
SKA: Fix kebab-case issues in obs-ux-logs packages (#211347)
(#211382)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.0`:\n- [SKA: Fix kebab-case issues in obs-ux-logs
packages\n(#211347)](https://github.com/elastic/kibana/pull/211347)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211347","number":211347,"mergeCommit":{"message":"SKA:
Fix kebab-case issues in obs-ux-logs packages (#211347)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/logs-overview` |
`x-pack/platform/packages/shared/logs-overview`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/logs-overview/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/logs-overview/jest.config.js:10\r\nx-pack/platform/packages/shared/logs-overview/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"0ecbbd52becb2d48150c837149d54125ddd5c6e3"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211383","number":211383,"state":"MERGED","mergeCommit":{"sha":"361ca2fadc19d6d7b8eb20d009b490d38ed701cb","message":"[8.x]
SKA: Fix kebab-case issues in obs-ux-logs packages (#211347)
(#211383)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [SKA: Fix kebab-case issues in obs-ux-logs
packages\n(#211347)](https://github.com/elastic/kibana/pull/211347)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants