Skip to content

[8.x] [Scout] add maps test (#204607)#211350

Merged
dmlemeshko merged 2 commits intoelastic:8.xfrom
dmlemeshko:backport/8.x/pr-204607
Feb 17, 2025
Merged

[8.x] [Scout] add maps test (#204607)#211350
dmlemeshko merged 2 commits intoelastic:8.xfrom
dmlemeshko:backport/8.x/pr-204607

Conversation

@dmlemeshko
Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko commented Feb 15, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@wayneseymour
[Scout] add maps test (elastic#204607)
0dbaec9 
## Summary

Add MapsPage to the scout core to be re-used by others.
Add rudimentary docs to show how to run these tests.
Added a `waitForRender` method.
Add test id.

---------

Co-authored-by: Robert Oskamp <traeluki@gmail.com>
Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
(cherry picked from commit ce19045)

# Conflicts:
#	.buildkite/scripts/steps/functional/scout_ui_tests.sh
#	.github/CODEOWNERS
#	x-pack/platform/plugins/shared/maps/tsconfig.json
@dmlemeshko dmlemeshko added the backport This PR is a backport of another PR label Feb 15, 2025
@dmlemeshko dmlemeshko enabled auto-merge (squash) February 15, 2025 11:38
@dmlemeshko dmlemeshko mentioned this pull request Feb 15, 2025
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / ObservabilityApp o11y sidenav sidenav & breadcrumbs renders the correct nav and navigate to links

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/scout 85 87 +2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/scout 9 11 +2
Unknown metric groups

API count

id before after diff
@kbn/scout 113 115 +2

ESLint disabled line counts

id before after diff
maps 51 52 +1

Total ESLint disabled count

id before after diff
maps 78 79 +1

History

@dmlemeshko dmlemeshko requested a review from pheyos February 17, 2025 12:49
pheyos
pheyos approved these changes Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit a4e5dab into elastic:8.x Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pheyos pheyos pheyos approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmlemeshko @elasticmachine @pheyos @wayneseymour