Skip to content

[ML] Adds icon to the Anomalies Table if detector has rules#21135

Merged
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-anomalies-table-rule-icon
Jul 24, 2018
Merged

[ML] Adds icon to the Anomalies Table if detector has rules#21135
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-anomalies-table-rule-icon

Conversation

@peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jul 24, 2018

Adds an icon alongside the description in the detector column of the Anomalies Table if a rule has been configured for the detector.

image

Note that currently after adding or removing a rule for a detector, the icon is only updated by doing a page refresh of the Anomaly Explorer / Single Metric Viewer. Dynamic updating of the icon after the rules have been edited in the Rule Editor Flyout will be addressed in a separate issue.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 49db091 into elastic:master Jul 24, 2018
@peteharverson peteharverson deleted the ml-anomalies-table-rule-icon branch July 24, 2018 13:22
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jul 24, 2018
…21135)

* [ML] Adds icon to the Anomalies Table if detector has rules

* [ML] Edit to tooltip message on anomalies table detetor rule icon
peteharverson added a commit that referenced this pull request Jul 24, 2018
…21142)

* [ML] Adds icon to the Anomalies Table if detector has rules

* [ML] Edit to tooltip message on anomalies table detetor rule icon
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants