Skip to content

[Index Management + ML] Remove unused code from index management and ml#211266

Merged
Samiul-TheSoccerFan merged 11 commits intoelastic:mainfrom
Samiul-TheSoccerFan:remove-unused-code-from-index-management-and-ml
Feb 26, 2025
Merged

[Index Management + ML] Remove unused code from index management and ml#211266
Samiul-TheSoccerFan merged 11 commits intoelastic:mainfrom
Samiul-TheSoccerFan:remove-unused-code-from-index-management-and-ml

Conversation

@Samiul-TheSoccerFan
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan commented Feb 14, 2025 •
edited by kibanamachine
Loading

Summary

This PR includes

  • Remove unused package from kibana
  • Remove references from index_management and ml plugins
  • Update translations file
  • Delete skipped tests

Closes #204507

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@Samiul-TheSoccerFan Samiul-TheSoccerFan added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) t// backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 14, 2025
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested review from a team as code owners February 14, 2025 16:18
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025

Pinging @elastic/kibana-management (Team:Kibana Management)

@Samiul-TheSoccerFan
Copy link
Contributor Author

Samiul-TheSoccerFan commented Feb 14, 2025

@saarikabhasi As per git commits, adding you as reviewer for this PR. Please feel free to add more reviewers if needed.

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 14, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7882

[✅] x-pack/test/functional/apps/index_management/config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/apis/ml/config.ts: 25/25 tests passed.

see run history

@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the remove-unused-code-from-index-management-and-ml branch from 3e9b1c1 to f546b1d Compare February 14, 2025 19:10
@Samiul-TheSoccerFan Samiul-TheSoccerFan added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Feb 14, 2025
@darnautov
Copy link
Contributor

darnautov commented Feb 17, 2025

@Samiul-TheSoccerFan there are some skipped functional tests that utilize removed API https://github.com/darnautov/kibana/blob/cbaddbe2b2da7c8c90cb91dac001a1a087d365d9/x-pack/test_serverless/functional/test_suites/search/inference_management.ts#L65, could you please delete them as well?

sabarasaba
sabarasaba approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code deleted from index management plugin lgtm

@Samiul-TheSoccerFan
Copy link
Contributor Author

Samiul-TheSoccerFan commented Feb 18, 2025

@elasticmachine merge upstream

saarikabhasi
saarikabhasi approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@saarikabhasi saarikabhasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the remove-unused-code-from-index-management-and-ml branch from 6651940 to bd6ad3e Compare February 20, 2025 23:02
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested a review from a team as a code owner February 20, 2025 23:02
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner February 20, 2025 23:13
alvarezmelissa87
alvarezmelissa87 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML code LGTM ⚡

@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the remove-unused-code-from-index-management-and-ml branch from 718a7f3 to 3df6185 Compare February 26, 2025 15:19
TattdCodeMonkey
TattdCodeMonkey approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description to close the skipped test issue since you're deleting that test.

Other changes LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 26, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 691 690 -1
ml 2415 2403 -12
total -13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/inference_integration_flyout 7 - -7

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/inference_integration_flyout 1 - -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 713.0KB 712.8KB -151.0B
ml 5.2MB 5.2MB +80.0B
total -71.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/inference_integration_flyout 1 - -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 77.2KB 77.1KB -138.0B
Unknown metric groups

API count

id before after diff
@kbn/inference_integration_flyout 7 - -7

History

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 26, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7957

[✅] x-pack/test/functional/apps/index_management/config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/apis/ml/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/apis/search/config.ts: 25/25 tests passed.

see run history

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit 5270cc6 into elastic:main Feb 26, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 26, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13553428636

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 26, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- SKA: Update and breakdown x-pack/.gitignore (#212341)
- SKA: Relocate "platform" packages that remain on /packages (#208704)

Manual backport

To create the backport manually run:

node scripts/backport --pr 211266

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 26, 2025
@Samiul-TheSoccerFan
[Index Management + ML] Remove unused code from index management and …
f2a6848 
…ml (elastic#211266)

## Summary

This PR includes
- Remove unused package from kibana
- Remove references from index_management and ml plugins
- Update translations file
- Delete skipped tests

Closes elastic#204507

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5270cc6)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/platform/packages/private/ml/inference_integration_flyout/components/flyout_layout.tsx
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
#	x-pack/platform/plugins/shared/ml/public/application/services/ml_api_service/inference_models.ts
#	x-pack/test_serverless/functional/test_suites/search/inference_management.ts
@Samiul-TheSoccerFan Samiul-TheSoccerFan mentioned this pull request Feb 26, 2025
Merged
@Samiul-TheSoccerFan
Copy link
Contributor Author

Samiul-TheSoccerFan commented Feb 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
@Samiul-TheSoccerFan @kibanamachine @JoseLuisGJ
[Index Management + ML] Remove unused code from index management and …
1671da5 
…ml (elastic#211266)

## Summary

This PR includes
- Remove unused package from kibana
- Remove references from index_management and ml plugins
- Update translations file
- Delete skipped tests

Closes elastic#204507

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Samiul-TheSoccerFan added a commit that referenced this pull request Feb 27, 2025
@Samiul-TheSoccerFan @kibanamachine
[8.x] [Index Management + ML] Remove unused code from index managemen…
bcfb4f4 
…t and ml (#211266) (#212591)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Management + ML] Remove unused code from index management and
ml (#211266)](#211266)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-26T21:09:44Z","message":"[Index
Management + ML] Remove unused code from index management and ml
(#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Team:ML","ci:project-deploy-elasticsearch","backport:version","v9.1.0","v8.19.0"],"title":"[Index
Management + ML] Remove unused code from index management and
ml","number":211266,"url":"https://github.com/elastic/kibana/pull/211266","mergeCommit":{"message":"[Index
Management + ML] Remove unused code from index management and ml
(#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211266","number":211266,"mergeCommit":{"message":"[Index
Management + ML] Remove unused code from index management and ml
(#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
@Samiul-TheSoccerFan @kibanamachine @SoniaSanzV
[8.x] [Index Management + ML] Remove unused code from index managemen…
4278dc3 
…t and ml (elastic#211266) (elastic#212591)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Management + ML] Remove unused code from index management and
ml (elastic#211266)](elastic#211266)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-26T21:09:44Z","message":"[Index
Management + ML] Remove unused code from index management and ml
(elastic#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Team:ML","ci:project-deploy-elasticsearch","backport:version","v9.1.0","v8.19.0"],"title":"[Index
Management + ML] Remove unused code from index management and
ml","number":211266,"url":"https://github.com/elastic/kibana/pull/211266","mergeCommit":{"message":"[Index
Management + ML] Remove unused code from index management and ml
(elastic#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211266","number":211266,"mergeCommit":{"message":"[Index
Management + ML] Remove unused code from index management and ml
(elastic#211266)\n\n## Summary\n\nThis PR includes\n- Remove unused package
from kibana\n- Remove references from index_management and ml plugins\n-
Update translations file\n- Delete skipped tests\n\nCloses
https://github.com/elastic/kibana/issues/204507\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [X] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5270cc621f18f8104338db046ff4c275e7c68769"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
@Samiul-TheSoccerFan @kibanamachine @CAWilson94
[Index Management + ML] Remove unused code from index management and …
0681430 
…ml (elastic#211266)

## Summary

This PR includes
- Remove unused package from kibana
- Remove references from index_management and ml plugins
- Update translations file
- Delete skipped tests

Closes elastic#204507

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@saarikabhasi saarikabhasi saarikabhasi approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Team:ML Team label for ML (also use :ml) t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

9 participants

@Samiul-TheSoccerFan @elasticmachine @kibanamachine @darnautov @sabarasaba @TattdCodeMonkey @alvarezmelissa87 @dmlemeshko @saarikabhasi