🌊 Streams - Better error handling#211197
Merged
flash1293 merged 3 commits intoelastic:mainfrom Feb 14, 2025
Merged
Conversation
flash1293
added
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13333122093 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
flash1293
added a commit
that referenced
this pull request
Feb 18, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
In a bunch of places we would directly show `error.message` in toasts. This is not always the right value, because the actual error is sometimes wrapped in an HttpError. At some places we would already unpack this correctly using a helper function - I made sure it's used everywhere. One example where this can be tested is when trying to map a child in an incompatible way - let's say a field is mapped as long in `logs.child.subchild`, then the user tries to map the same field as keyword in `logs.child`. Previously it would just say "BadRequest", now it says: <img width="378" alt="Screenshot 2025-02-14 at 15 02 53" src="https://github.com/user-attachments/assets/0abb51db-2bac-407e-bb51-beb74b3f9adb" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a bunch of places we would directly show
error.messagein toasts. This is not always the right value, because the actual error is sometimes wrapped in an HttpError. At some places we would already unpack this correctly using a helper function - I made sure it's used everywhere.One example where this can be tested is when trying to map a child in an incompatible way - let's say a field is mapped as long in
logs.child.subchild, then the user tries to map the same field as keyword inlogs.child. Previously it would just say "BadRequest", now it says: