Deprecate test:ui commands#21092
Merged
rhoboat merged 3 commits intoelastic:masterfrom Jul 23, 2018
rhoboat:deprecate-commands
Merged
Deprecate test:ui commands#21092rhoboat merged 3 commits intoelastic:masterfrom rhoboat:deprecate-commands
rhoboat merged 3 commits intoelastic:masterfrom
rhoboat:deprecate-commands
Conversation
rhoboat
added
the
Team:Core
Contributor
💚 Build Succeeded |
spalger
approved these changes
Jul 23, 2018
|
|
||
| grunt.registerTask('test:ui:server', [ | ||
| 'checkPlugins', | ||
| 'run:functionalTestsDevServer', |
Contributor
There was a problem hiding this comment.
Looks like we can get rid of this config from tasks/config/run.js
| grunt.registerTask('test:quick', [ | ||
| 'test:server', | ||
| 'test:ui', | ||
| 'checkPlugins', |
Contributor
There was a problem hiding this comment.
Might as well move checkPlugins to the top of the task, since it's advisory and when it's buried under the output from test:server it is harder to notice.
Author
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta: #12699
Parent issue: #18568
Sub parent issue: #18967
Follow up task to clean up old test:ui commands in favor of
node scripts/functional_test*commands.