[9.0] [Lens] Restore dynamic colouring by value for Last value agg (#209110)#210885
Merged
kibanamachine merged 1 commit intoelastic:9.0from Feb 12, 2025
Merged
Conversation
…#209110) ## Summary Fixes elastic#208924 This PR improves the numeric check for the Last value agg within the Metric chart type avoiding completely to access the active data and rather rely on the datasource configuration. The new utility function in fact won't rely any more on active data rather on the Lens configuration itself, which is more robust, faster and flexible. <img width="2552" alt="Screenshot 2025-01-31 at 14 30 12" src="https://github.com/user-attachments/assets/5f8792db-40ff-497b-8e2f-0737c2932f92" /> ### Notes for testing I've created a testing dashboard with all the possible combinations of colouring for metric and tables. [last_value_dashboard.ndjson.txt](https://github.com/user-attachments/files/18618905/last_value_dashboard.ndjson.txt) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Release note This fixes an issue where dynamic colouring has been disabled from Last value aggregation types. (cherry picked from commit abba667)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
cc @dej611 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation