[Lens][Embeddable] Make UI react faster to click actions like create or edit#210810
Merged
dej611 merged 10 commits intoelastic:mainfrom Feb 20, 2025
Merged
[Lens][Embeddable] Make UI react faster to click actions like create or edit#210810dej611 merged 10 commits intoelastic:mainfrom
dej611 merged 10 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
dej611
added
Team:Visualizations
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
jbudz
approved these changes
Feb 14, 2025
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
packages/kbn-optimizer/limits.yml LGTM
nickofthyme
approved these changes
Feb 18, 2025
Contributor
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
Changes LGTM, tested locally and it's much snappier!
x-pack/platform/plugins/shared/lens/public/react_embeddable/helper.ts
Outdated
Show resolved
Hide resolved
…lper.ts Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @dej611 |
dej611
added
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13440977640 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
4 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
dej611
added a commit
that referenced
this pull request
Mar 3, 2025
…reate or edit (#210810) (#212052) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Make UI react faster to click actions like create or edit (#210810)](#210810) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:19:46Z","message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (#210810)\n\n## Summary\n\nThis PR is based on the idea in #209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0"],"title":"[Lens][Embeddable] Make UI react faster to click actions like create or edit","number":210810,"url":"https://github.com/elastic/kibana/pull/210810","mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (#210810)\n\n## Summary\n\nThis PR is based on the idea in #209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210810","number":210810,"mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (#210810)\n\n## Summary\n\nThis PR is based on the idea in #209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…reate or edit (elastic#210810) (elastic#212052) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)](elastic#210810) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:19:46Z","message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0"],"title":"[Lens][Embeddable] Make UI react faster to click actions like create or edit","number":210810,"url":"https://github.com/elastic/kibana/pull/210810","mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210810","number":210810,"mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…or edit (elastic#210810) ## Summary This PR is based on the idea in elastic#209361 and tries to improve perceived performances for all the scenarios where the `editorFrame` is loaded. On fast connections this is now perceived very fast:  On Fast 4g is still fast  On Slow 4g is acceptable  Even on 3G connection the feedback is much better now  As a bonus extra tests have been added for the ES|QL creation flow. cc @thomasneirynck @nreese ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on the idea in #209361 and tries to improve perceived performances for all the scenarios where the
editorFrameis loaded.On fast connections this is now perceived very fast:
On Fast 4g is still fast
On Slow 4g is acceptable
Even on 3G connection the feedback is much better now
As a bonus extra tests have been added for the ES|QL creation flow.
cc @thomasneirynck @nreese
Checklist