[ML] Job validation won't report an error when categorization job is using mlcategory#21075
Merged
walterra merged 1 commit intoelastic:masterfrom Jul 23, 2018
Merged
Conversation
walterra
added
bug
Contributor
|
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
Jul 23, 2018
| // then don't report the field as not being able to be aggregated. | ||
| if (!( | ||
| typeof job.analysis_config.categorization_field_name !== 'undefined' && | ||
| uniqueFieldName === 'mlcategory' |
Member
There was a problem hiding this comment.
the mlcategory string is repeated a lot throughout our code base. It would probably be better as a constant.
Out of scope for this PR, just mentioning it.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 23, 2018
…b is properly setup. (elastic#21075) For categorization jobs, job validation would report that mlcategory isn't an aggregatable field. This fix checks the job configuration and only reports the error if the job config isn't using categorization_field_name and the detector field isn't set to mlcategory.
walterra
added a commit
that referenced
this pull request
Jul 23, 2018
…b is properly setup. (#21075) (#21082) For categorization jobs, job validation would report that mlcategory isn't an aggregatable field. This fix checks the job configuration and only reports the error if the job config isn't using categorization_field_name and the detector field isn't set to mlcategory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20867.
For categorization jobs, job validation would report that
mlcategoryisn't an aggregatable field.This fix checks the job configuration and only reports the error if the job config isn't using
categorization_field_nameand the detector field isn't set tomlcategory.