[8.x] [Embeddable] Fix presentation panel styles (#210113)#210710
Merged
Heenawter merged 2 commits intoelastic:8.xfrom Feb 12, 2025
Merged
[8.x] [Embeddable] Fix presentation panel styles (#210113)#210710Heenawter merged 2 commits intoelastic:8.xfrom
Heenawter merged 2 commits intoelastic:8.xfrom
Conversation
## Summary When elastic#207275 merged, some Security Cypress tests started failing because the embeddables were no longer taking up any width in their containers. This was caused by us switching over to using the CSS container type `inline-size` on the hover anchor wrapper, which makes it so that it can no longer be sized to its contents (see [this comment](https://stackoverflow.com/a/73980194/28754956) for a really good explanation). Instead, the width of the `PresentationPanel` needs to be set **by the parent** - so, by applying the `min-width` to the Metric wrapper rather than the Lens embeddable, the metric now takes up the expected width: | Before | After | |--------|--------| |  |  | When doing this work, I noticed that, because we added a delay to hiding the hover actions, there was a slightly jarring transition when hovering over panels without `border` enabled. So, I fixed this by adding a transition to the border on the panel as well, so that it matches the animation on the hover actions: | Before | After | |--------|--------| |  |  | ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 3716441) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/explore/inspect/inspect_button.cy.ts
2 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
ThomThomson
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation