[9.0] [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)#210677
Merged
kibanamachine merged 1 commit intoelastic:9.0from Feb 11, 2025
Conversation
…s not used (elastic#210613) ## Summary Closes elastic#210610 This PR removes `error.id` field from being queried at `getErrorGroupMainStatistics`, as it was not being used, as it was required. If we didn't have this field, the endpoint call would crash. (cherry picked from commit 46cd29e)
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💚 Build Succeeded
Metrics [docs]
cc @rmyz |
rmyz
added a commit
that referenced
this pull request
Feb 12, 2025
…as it's not used (#210613) (#210761) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)](#210613) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:13:51Z","message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","backport:8.17","v9.1.0","backport:8.18"],"title":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used","number":210613,"url":"https://github.com/elastic/kibana/pull/210613","mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210677","number":210677,"state":"MERGED","mergeCommit":{"sha":"dbe7cc3b4f4b21484f5bb4b26e47fbe541b83fab","message":"[9.0] [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613) (#210677)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[APM] Remove `error.id` in\n`getErrorGroupMainStatistics` query as it's not used\n(#210613)](https://github.com/elastic/kibana/pull/210613)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Sergi\nRomeu\",\"email\":\"sergi.romeu@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2025-02-11T18:13:51Z\",\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"v9.0.0\",\"apm\",\"Team:obs-ux-infra_services\",\"backport:version\",\"backport:8.17\",\"v9.1.0\",\"backport:8.18\"],\"title\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused\",\"number\":210613,\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"9.0\"],\"targetPullRequestStates\":[{\"branch\":\"9.0\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"number\":210613,\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210613","number":210613,"mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}}]}] BACKPORT-->
rmyz
added a commit
that referenced
this pull request
Feb 12, 2025
… as it's not used (#210613) (#210762) # Backport This will backport the following commits from `main` to `8.18`: - [[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)](#210613) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:13:51Z","message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","backport:8.17","v9.1.0","backport:8.18"],"title":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used","number":210613,"url":"https://github.com/elastic/kibana/pull/210613","mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210677","number":210677,"state":"MERGED","mergeCommit":{"sha":"dbe7cc3b4f4b21484f5bb4b26e47fbe541b83fab","message":"[9.0] [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613) (#210677)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[APM] Remove `error.id` in\n`getErrorGroupMainStatistics` query as it's not used\n(#210613)](https://github.com/elastic/kibana/pull/210613)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Sergi\nRomeu\",\"email\":\"sergi.romeu@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2025-02-11T18:13:51Z\",\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"v9.0.0\",\"apm\",\"Team:obs-ux-infra_services\",\"backport:version\",\"backport:8.17\",\"v9.1.0\",\"backport:8.18\"],\"title\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused\",\"number\":210613,\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"9.0\"],\"targetPullRequestStates\":[{\"branch\":\"9.0\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"number\":210613,\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210613","number":210613,"mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}}]}] BACKPORT-->
rmyz
added a commit
that referenced
this pull request
Feb 12, 2025
… as it's not used (#210613) (#210763) # Backport This will backport the following commits from `main` to `8.17`: - [[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)](#210613) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:13:51Z","message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","backport:8.17","v9.1.0","backport:8.18"],"title":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used","number":210613,"url":"https://github.com/elastic/kibana/pull/210613","mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210677","number":210677,"state":"MERGED","mergeCommit":{"sha":"dbe7cc3b4f4b21484f5bb4b26e47fbe541b83fab","message":"[9.0] [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613) (#210677)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[APM] Remove `error.id` in\n`getErrorGroupMainStatistics` query as it's not used\n(#210613)](https://github.com/elastic/kibana/pull/210613)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Sergi\nRomeu\",\"email\":\"sergi.romeu@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2025-02-11T18:13:51Z\",\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"v9.0.0\",\"apm\",\"Team:obs-ux-infra_services\",\"backport:version\",\"backport:8.17\",\"v9.1.0\",\"backport:8.18\"],\"title\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused\",\"number\":210613,\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"9.0\"],\"targetPullRequestStates\":[{\"branch\":\"9.0\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210613\",\"number\":210613,\"mergeCommit\":{\"message\":\"[APM]\nRemove `error.id` in `getErrorGroupMainStatistics` query as it's not\nused (#210613)\\n\\n## Summary\\n\\nCloses #210610\\n\\nThis PR removes\n`error.id` field from being queried at\\n`getErrorGroupMainStatistics`,\nas it was not being used, as it was\\nrequired. If we didn't have this\nfield, the endpoint call would\ncrash.\",\"sha\":\"46cd29e60be24fa3d39b2b364973e0e9b10659b7\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210613","number":210613,"mergeCommit":{"message":"[APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (#210613)\n\n## Summary\n\nCloses #210610\n\nThis PR removes `error.id` field from being queried at\n`getErrorGroupMainStatistics`, as it was not being used, as it was\nrequired. If we didn't have this field, the endpoint call would crash.","sha":"46cd29e60be24fa3d39b2b364973e0e9b10659b7"}},{"url":"https://github.com/elastic/kibana/pull/210761","number":210761,"branch":"8.x","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/210762","number":210762,"branch":"8.18","state":"OPEN"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation