Skip to content

[8.18] [Cloud Security] Adding telemetry collection condition based on render condition (#208758) #210634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Feb 11, 2025
Merged

[8.18] [Cloud Security] Adding telemetry collection condition based on render condition (#208758) #210634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/platform/packages/shared/kbn-cloud-security-posture/common/utils/ui_metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import type { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';

export const APP_NAME = 'cloud-security';

export const MISCONFIGURATION_INSIGHT = 'misconfiguration-insight' as const;
export const VULNERABILITIES_INSIGHT = 'vulnerabilities-insight' as const;
export const MISCONFIGURATION_INSIGHT = 'misconfiguration-insight-v2' as const;
export const VULNERABILITIES_INSIGHT = 'vulnerabilities-insight-v2' as const;
export const MISCONFIGURATION_INSIGHT_HOST_DETAILS =
`${MISCONFIGURATION_INSIGHT}-host-details` as const;
export const MISCONFIGURATION_INSIGHT_USER_DETAILS =
Expand Down
16 changes: 8 additions & 8 deletions ...ty_solution/public/flyout/document_details/shared/components/misconfiguration_insight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ export const MisconfigurationsInsight: React.FC<MisconfigurationsInsightProps> =
'newExpandableFlyoutNavigationEnabled'
);

useEffect(() => {
if (telemetryKey) {
uiMetricService.trackUiMetric(METRIC_TYPE.COUNT, telemetryKey);
}
}, [telemetryKey, renderingId]);

const passedFindings = data?.count.passed || 0;
const failedFindings = data?.count.failed || 0;
const totalFindings = useMemo(
() => passedFindings + failedFindings,
[passedFindings, failedFindings]
);
const hasMisconfigurationFindings = totalFindings > 0;
const shouldRender = totalFindings > 0; // this component only renders if there are findings

useEffect(() => {
if (shouldRender && telemetryKey) {
uiMetricService.trackUiMetric(METRIC_TYPE.COUNT, telemetryKey);
}
}, [shouldRender, telemetryKey, renderingId]);

const misconfigurationsStats = useMemo(
() => getFindingsStats(passedFindings, failedFindings),
Expand Down Expand Up @@ -161,7 +161,7 @@ export const MisconfigurationsInsight: React.FC<MisconfigurationsInsightProps> =
]
);

if (!hasMisconfigurationFindings) return null;
if (!shouldRender) return null;

return (
<EuiFlexItem data-test-subj={dataTestSubj}>
Expand Down
17 changes: 9 additions & 8 deletions ...ity_solution/public/flyout/document_details/shared/components/vulnerabilities_insight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,14 @@ export const VulnerabilitiesInsight: React.FC<VulnerabilitiesInsightProps> = ({
'newExpandableFlyoutNavigationEnabled'
);

useEffect(() => {
if (telemetryKey) {
uiMetricService.trackUiMetric(METRIC_TYPE.COUNT, telemetryKey);
}
}, [telemetryKey, renderingId]);

const { CRITICAL = 0, HIGH = 0, MEDIUM = 0, LOW = 0, NONE = 0 } = data?.count || {};
const totalVulnerabilities = useMemo(
() => CRITICAL + HIGH + MEDIUM + LOW + NONE,
[CRITICAL, HIGH, MEDIUM, LOW, NONE]
);

const hasVulnerabilitiesFindings = useMemo(
// this component only renders if there are findings
const shouldRender = useMemo(
() =>
hasVulnerabilitiesData({
critical: CRITICAL,
Expand All @@ -106,6 +101,12 @@ export const VulnerabilitiesInsight: React.FC<VulnerabilitiesInsightProps> = ({
[CRITICAL, HIGH, MEDIUM, LOW, NONE]
);

useEffect(() => {
if (shouldRender && telemetryKey) {
uiMetricService.trackUiMetric(METRIC_TYPE.COUNT, telemetryKey);
}
}, [shouldRender, telemetryKey, renderingId]);

const vulnerabilitiesStats = useMemo(
() =>
getVulnerabilityStats({
Expand Down Expand Up @@ -172,7 +173,7 @@ export const VulnerabilitiesInsight: React.FC<VulnerabilitiesInsightProps> = ({
]
);

if (!hasVulnerabilitiesFindings) return null;
if (!shouldRender) return null;

return (
<EuiFlexItem data-test-subj={dataTestSubj}>
Expand Down