[Monitoring] Ignore Duplicate Shards#21057
Merged
pickypg merged 6 commits intoelastic:masterfrom Jul 24, 2018
Merged
Conversation
This eliminates duplicate shards from the shard table by actively ignoring them from the response.
pickypg
added
bug
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
|
Should we also remove this reference? |
Member
Author
|
@chrisronline Not in this PR. I am going to backport this PR, so I don't want to have to customize it before backporting (to keep the setting). I did create #21095 for that though. |
chrisronline
approved these changes
Jul 24, 2018
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
LGTM!
Functionality wise, I tested that the problem occurs before the code fix and goes away after the code fix.
The code makes sense too!
pickypg
added a commit
that referenced
this pull request
Jul 24, 2018
[Monitoring] Ignore Duplicate Shards This eliminates duplicate shards from the shard table by actively ignoring them from the response.
Member
Author
|
6.x/6.4: 20c97e5 This did not backport cleanly to 6.3, so I only backported the fix to 6.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates duplicate shards from the shard table by actively ignoring
them from the response.
Relates to #19704 (comment)