Skip to content

fixing accessibility issue with include system indices checkbox in index creation wizard#21034

Merged
bmcconaghy merged 3 commits intoelastic:masterfrom
bmcconaghy:accessibility_include_system_indices
Jul 23, 2018
Merged

fixing accessibility issue with include system indices checkbox in index creation wizard#21034
bmcconaghy merged 3 commits intoelastic:masterfrom
bmcconaghy:accessibility_include_system_indices

Conversation

@bmcconaghy
Copy link
Contributor

@bmcconaghy bmcconaghy commented Jul 20, 2018

An id appears to be required for the screen reader to pick up the label.

Closes #19128

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Tested locally and works as expected. Code looks good.

@cjcenizal cjcenizal changed the title fixing accessibility issue with include system indices checkbox in in… fixing accessibility issue with include system indices checkbox in index creation wizard Jul 20, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmcconaghy
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmcconaghy
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmcconaghy bmcconaghy merged commit 9e71f5c into elastic:master Jul 23, 2018
@bmcconaghy bmcconaghy deleted the accessibility_include_system_indices branch July 23, 2018 15:13
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Jul 23, 2018
…dex creation wizard (elastic#21034)

* fixing accessibility issue with include system indices checkbox in index creation wizard

* updating snapshots
bmcconaghy added a commit that referenced this pull request Jul 23, 2018
…dex creation wizard (#21034) (#21090)

* fixing accessibility issue with include system indices checkbox in index creation wizard

* updating snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants