[Security Solution][Expandable flyout] show last open in the history#210286
Merged
PhilippeOberti merged 4 commits intoelastic:mainfrom Feb 19, 2025
Merged
[Security Solution][Expandable flyout] show last open in the history#210286PhilippeOberti merged 4 commits intoelastic:mainfrom
PhilippeOberti merged 4 commits intoelastic:mainfrom
Conversation
PhilippeOberti
added
release_note:skip
PhilippeOberti
force-pushed
the
flyout-history-last-open
branch
4 times, most recently
from
1844340 to
e577de0
Compare
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
flyout-history-last-open
branch
from
e577de0 to
fdd9f18
Compare
christineweng
approved these changes
Feb 13, 2025
Contributor
christineweng
left a comment
christineweng
left a comment
There was a problem hiding this comment.
Desk tested and LGTM! Thanks for all the css magic! Left 2 small comments
x-pack/solutions/security/plugins/security_solution/public/flyout/shared/utils/history_utils.ts
Outdated
Show resolved
Hide resolved
...ns/security/plugins/security_solution/public/flyout/shared/components/flyout_history_row.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
force-pushed
the
flyout-history-last-open
branch
from
fdd9f18 to
a790964
Compare
jaredburgettelastic
approved these changes
Feb 18, 2025
Contributor
jaredburgettelastic
left a comment
jaredburgettelastic
left a comment
There was a problem hiding this comment.
Entity Analytics test file changes LGTM! 👍
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13403663594 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2025
…lastic#210286) ## Summary This PR makes a small UI addition to the expandable flyout package history functionality [merged not long ago](elastic#184970). We are snow saving the time at which a panel was opened, along side the panel's information. This allows us to show when previous flyout panels were opened, making it users easier for users to know which host/user/network/alerts/event document they recently looked at. The primary logic change happens in the expandable flyout package. Most of the other code changes are in Security Solution unit tests. #### Before  #### After  You'll notice in the screenshot above that another small improvement was added: we're limiting the width of the text rendered and show an ellipsis. This will prevent really long texts to have the popover really wide or to be rendered over multiple lines ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dd471d1)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Feb 19, 2025
…lastic#210286) ## Summary This PR makes a small UI addition to the expandable flyout package history functionality [merged not long ago](elastic#184970). We are snow saving the time at which a panel was opened, along side the panel's information. This allows us to show when previous flyout panels were opened, making it users easier for users to know which host/user/network/alerts/event document they recently looked at. The primary logic change happens in the expandable flyout package. Most of the other code changes are in Security Solution unit tests. #### Before  #### After  You'll notice in the screenshot above that another small improvement was added: we're limiting the width of the text rendered and show an ellipsis. This will prevent really long texts to have the popover really wide or to be rendered over multiple lines ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dd471d1) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/flyout/entity_details/host_right/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/entity_details/service_right/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/entity_details/user_right/index.test.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 19, 2025
…story (#210286) (#211667) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Expandable flyout] show last open in the history (#210286)](#210286) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T01:40:34Z","message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution][Expandable flyout] show last open in the history","number":210286,"url":"https://github.com/elastic/kibana/pull/210286","mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210286","number":210286,"mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
PhilippeOberti
added a commit
that referenced
this pull request
Feb 19, 2025
…story (#210286) (#211668) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution][Expandable flyout] show last open in the history (#210286)](#210286) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T01:40:34Z","message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution][Expandable flyout] show last open in the history","number":210286,"url":"https://github.com/elastic/kibana/pull/210286","mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210286","number":210286,"mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211667","number":211667,"state":"OPEN"}]}] BACKPORT-->
PhilippeOberti
added a commit
that referenced
this pull request
Feb 19, 2025
…istory (#210286) (#211669) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Expandable flyout] show last open in the history (#210286)](#210286) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T01:40:34Z","message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution][Expandable flyout] show last open in the history","number":210286,"url":"https://github.com/elastic/kibana/pull/210286","mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210286","number":210286,"mergeCommit":{"message":"[Security Solution][Expandable flyout] show last open in the history (#210286)\n\n## Summary\n\nThis PR makes a small UI addition to the expandable flyout package\nhistory functionality [merged not long\nago](https://github.com/elastic/kibana/pull/184970).\n\nWe are snow saving the time at which a panel was opened, along side the\npanel's information. This allows us to show when previous flyout panels\nwere opened, making it users easier for users to know which\nhost/user/network/alerts/event document they recently looked at.\n\nThe primary logic change happens in the expandable flyout package. Most\nof the other code changes are in Security Solution unit tests.\n\n#### Before\n\n\n\n#### After\n\n\n\nYou'll notice in the screenshot above that another small improvement was\nadded: we're limiting the width of the text rendered and show an\nellipsis. This will prevent really long texts to have the popover really\nwide or to be rendered over multiple lines\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dd471d10b25fdb44f5ff59a5a640b1e1d0873f17"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211667","number":211667,"state":"OPEN"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…lastic#210286) ## Summary This PR makes a small UI addition to the expandable flyout package history functionality [merged not long ago](elastic#184970). We are snow saving the time at which a panel was opened, along side the panel's information. This allows us to show when previous flyout panels were opened, making it users easier for users to know which host/user/network/alerts/event document they recently looked at. The primary logic change happens in the expandable flyout package. Most of the other code changes are in Security Solution unit tests. #### Before  #### After  You'll notice in the screenshot above that another small improvement was added: we're limiting the width of the text rendered and show an ellipsis. This will prevent really long texts to have the popover really wide or to be rendered over multiple lines ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a small UI addition to the expandable flyout package history functionality merged not long ago.
We are snow saving the time at which a panel was opened, along side the panel's information. This allows us to show when previous flyout panels were opened, making it users easier for users to know which host/user/network/alerts/event document they recently looked at.
The primary logic change happens in the expandable flyout package. Most of the other code changes are in Security Solution unit tests.
Before
After
You'll notice in the screenshot above that another small improvement was added: we're limiting the width of the text rendered and show an ellipsis. This will prevent really long texts to have the popover really wide or to be rendered over multiple lines
Checklist