Change painless scripted field #21026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
bug
Contributor
💔 Build Failed |
nreese
approved these changes
Jul 20, 2018
Contributor
|
Looks like the new script does not compile. Needs to be changed to I removed the |
nreese
reviewed
Jul 20, 2018
| const script = `if (doc[\'machine.ram\'].size() == 0) { | ||
| return -1; | ||
| } else { | ||
| return doc[\'machine.ram\'].value / (1024 * 1024 * 1024)'; |
Contributor
There was a problem hiding this comment.
There is an extra ' at the end of this line that is invalid
added 2 commits
July 20, 2018 15:37
cjcenizal
approved these changes
Jul 20, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM thanks for hopping on this so quickly everyone.
Contributor
💔 Build Failed |
Contributor
|
Retest |
Contributor
|
The CI failed on X-Pack:
|
Contributor
|
Retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
We made it! |
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Jul 20, 2018
* Change painless scripted field * Remove wrong char * Remove invalid escape chars
nreese
added a commit
that referenced
this pull request
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to elastic/elasticsearch#32207 our functional tests started failing on
master.This PR changes the scripted field, that was failing to do the appropriate check if an actual value is present in the document.