[8.x] [Expandable Flyout] - customize default right, left and preview widths for push mode (#206155)#210117
Merged
PhilippeOberti merged 2 commits intoelastic:8.xfrom Feb 7, 2025
Conversation
…s for push mode (elastic#206155) ## Summary This PR is making some changes to the Expandable Flyout package. Prior work had added [push mode](elastic#182615) to the package, added [custom way](elastic#170078) to handle the width for multiple resolutions, and [added support](elastic#192906) for the internal section to be resiable by users. This PR improves the default user experience when using the flyout in push mode. Until now, the default `right`, `left` and `preview` width in `push` mode and `overlay` mode were identical. This meant that the flyout rendered in `push` mode was most of the time using the whole screen, not leaving any room to the rest of the page content (like the alerts table). The `push` widths are now calculated in a different way, to leave as much room as possible while still allowing the flyout `right` and `left` sections to render their content correctly, at least most of the time. Users can still resize the whole flyout as well as the internal `right` and `left` sections. The `push` widths are generally smaller/narrower than the `overlay` widths. #### The `overlay` mode default widths have not changed https://github.com/user-attachments/assets/28b6c41e-b12c-45cf-aa3e-026a7acdb7b3 #### The `push` mode default widths https://github.com/user-attachments/assets/93706f9e-212b-4cb4-8748-552f2daed585 ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e7140ff) # Conflicts: # x-pack/solutions/security/packages/expandable-flyout/src/components/preview_section.tsx
2 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
christineweng
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation