Skip to content

[Embeddable] Fix presentation panel styles #210113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Heenawter merged 4 commits into from
Feb 11, 2025
+17 −8
Merged

[Embeddable] Fix presentation panel styles #210113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70d0cac
Try to fix Cypress tests
Heenawter Feb 6, 2025
ef9f6d2
Better fix
Heenawter Feb 7, 2025
08017e3
Fix that doesn't break ML test
Heenawter Feb 7, 2025
3d83102
Merge branch 'main' into fix-cypress-tests_2025-02-06
Heenawter Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions ...ivate/presentation_panel/public/panel_component/panel_header/use_hover_actions_styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ export const useHoverActionStyles = (isEditMode: boolean, showBorder?: boolean)
${isEditMode ? editModeOutline : viewModeOutline}
);

display: inline-block;
container: hoverActionsAnchor / inline-size;
border-radius: ${euiTheme.border.radius.medium};
position: relative;
display: inline-block;
vertical-align: top;
width: 100%;
height: 100%;

Expand All @@ -41,9 +42,19 @@ export const useHoverActionStyles = (isEditMode: boolean, showBorder?: boolean)
}
`
: css`
.embPanel {
outline: 1px solid transparent; // necessary for outline-color transition
z-index: ${euiTheme.levels.content}; // necessary for z-index transition
// delay hiding border on hover out to match delay on hover actions
transition: outline-color ${euiTheme.animation.extraFast},
z-index ${euiTheme.animation.extraFast};
transition-delay: ${euiTheme.animation.fast};
}

&:hover .embPanel {
outline: var(--internalBorderStyle);
z-index: ${euiTheme.levels.menu};
transition: none; // apply transition on hover out only
}
`}

Expand All @@ -55,9 +66,9 @@ export const useHoverActionStyles = (isEditMode: boolean, showBorder?: boolean)
visibility: hidden;

// delay hiding hover actions to make grabbing the drag handle easier
transition: ${euiTheme.animation.extraFast} opacity ease-in,
${euiTheme.animation.extraFast} z-index linear,
${euiTheme.animation.extraFast} visibility linear;
transition: opacity ${euiTheme.animation.extraFast} ease-in,
z-index ${euiTheme.animation.extraFast} linear,
visibility ${euiTheme.animation.extraFast} linear;
transition-delay: ${euiTheme.animation.fast};
}

Expand Down
1 change: 1 addition & 0 deletions ...lutions/security/plugins/security_solution/public/explore/components/stat_items/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export const MetricItem = styled(EuiFlexItem)`
&.euiFlexItem {
flex-basis: 0;
flex-grow: 0;
min-width: 100px;
}
`;
MetricItem.displayName = 'MetricItem';
Expand Down
5 changes: 1 addition & 4 deletions x-pack/test/security_solution_cypress/cypress/e2e/explore/inspect/inspect_button.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ import { mockRiskEngineEnabled } from '../../../tasks/entity_analytics';

const DATA_VIEW = 'auditbeat-*';

// Failing: See https://github.com/elastic/kibana/issues/199563
// Failing: See https://github.com/elastic/kibana/issues/199583
// Failing: See https://github.com/elastic/kibana/issues/178367
describe.skip('Inspect Explore pages', { tags: ['@ess', '@serverless'] }, () => {
describe('Inspect Explore pages', { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
// illegal_argument_exception: unknown setting [index.lifecycle.name]
cy.task('esArchiverLoad', { archiveName: 'risk_scores_new' });
Expand Down