Skip to content

[8.18] [Security Solution] Adds callback onUpdatePageIndex to get current pageIndex in Unified Data table (#201240) #210047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
logeekal wants to merge 2 commits into from
Closed

[8.18] [Security Solution] Adds callback onUpdatePageIndex to get current pageIndex in Unified Data table (#201240) #210047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f0c6a1
[Security Solution] Adds callback `onUpdatePageIndex` to get current …
logeekal Nov 29, 2024
5038b8b
fix: merge issue. remove obsolete file
logeekal Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...k/solutions/security/plugins/security_solution/public/timelines/containers/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,9 @@ describe('useTimelineEvents', () => {
>((args) => useTimelineEvents(args), {
initialProps: { ...props, startDate: '', endDate: '' },
});

// useEffect on params request
await waitFor(() => new Promise((resolve) => resolve(null)));
rerender({ ...props, startDate, endDate });
rerender({ ...props, startDate: '', endDate: '' });
// useEffect on params request
await waitFor(() => {
expect(mockSearch).toHaveBeenCalledTimes(2);
Expand Down Expand Up @@ -286,7 +285,7 @@ describe('useTimelineEvents', () => {
// useEffect on params request
await waitFor(() => new Promise((resolve) => resolve(null)));

expect(mockSearch).toHaveBeenCalledTimes(2);
expect(mockSearch).toHaveBeenCalledTimes(1);
mockSearch.mockClear();

rerender({
Expand All @@ -310,7 +309,7 @@ describe('useTimelineEvents', () => {
// useEffect on params request
await waitFor(() => new Promise((resolve) => resolve(null)));

expect(mockSearch).toHaveBeenCalledTimes(2);
expect(mockSearch).toHaveBeenCalledTimes(1);
mockSearch.mockClear();

rerender({ ...props, startDate, endDate, fields: ['@timestamp'] });
Expand All @@ -329,7 +328,7 @@ describe('useTimelineEvents', () => {
// useEffect on params request
await waitFor(() => new Promise((resolve) => resolve(null)));

expect(mockSearch).toHaveBeenCalledTimes(2);
expect(mockSearch).toHaveBeenCalledTimes(1);
mockSearch.mockClear();

// remove `event.kind` from default fields
Expand Down