[EDR Workflows] Fix agent count on policy deploy modal#209593
Merged
gergoabraham merged 6 commits intoelastic:mainfrom Feb 6, 2025
Merged
[EDR Workflows] Fix agent count on policy deploy modal#209593gergoabraham merged 6 commits intoelastic:mainfrom
gergoabraham merged 6 commits intoelastic:mainfrom
Conversation
gergoabraham
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
gergoabraham
commented
Feb 4, 2025
Comment on lines
+125
to
+129
| // skipping Advanced Options as changing them takes too long. | ||
| // todo: re-enable them with this issue: https://github.com/elastic/security-team/issues/11765 | ||
| // await userEvent.click(getByTestId(testSubj.advancedSection.showHideButton)); | ||
| // await userEvent.type(getByTestId('linux.advanced.agent.connection_delay'), '1000'); | ||
| // set(policySettings, 'linux.advanced.agent.connection_delay', '1000'); |
Contributor
Author
There was a problem hiding this comment.
the test cases calling makeUpdates() used to timeout on CI, due to taking more time than 15 sec: #179984
on my machine, any of these test cases took ca. 4.5 sec alone.
by commenting out the lines above, it is reduced to 1.6 sec.
additionally, in test cases that don't need all changes, I've switched to a makeMinimalUpdates(), which further reduced the time of those test cases to 0.5 sec.
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
joeypoon
approved these changes
Feb 5, 2025
szwarckonrad
approved these changes
Feb 6, 2025
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13181975435 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 16fae1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 16fae1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 16fae1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 16fae1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 16fae1c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
## Summary Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same `active` field instead of `all`, as the `AgentSummary` component. Also, re-enables flaky unit test for `PolicySettingsLayout`: closes: elastic#179984 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added a commit
that referenced
this pull request
Feb 7, 2025
#210045) # Backport This will backport the following commits from `main` to `9.0`: - [[EDR Workflows] Fix agent count on policy deploy modal (#209593)](#209593) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:17:47Z","message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix agent count on policy deploy modal","number":209593,"url":"https://github.com/elastic/kibana/pull/209593","mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209593","number":209593,"mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 7, 2025
… (#210043) # Backport This will backport the following commits from `main` to `8.18`: - [[EDR Workflows] Fix agent count on policy deploy modal (#209593)](#209593) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:17:47Z","message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix agent count on policy deploy modal","number":209593,"url":"https://github.com/elastic/kibana/pull/209593","mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209593","number":209593,"mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}}]}] BACKPORT--> --------- Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 7, 2025
… (#210042) # Backport This will backport the following commits from `main` to `8.17`: - [[EDR Workflows] Fix agent count on policy deploy modal (#209593)](#209593) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:17:47Z","message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix agent count on policy deploy modal","number":209593,"url":"https://github.com/elastic/kibana/pull/209593","mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209593","number":209593,"mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}}]}] BACKPORT--> --------- Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 7, 2025
… (#210041) # Backport This will backport the following commits from `main` to `8.16`: - [[EDR Workflows] Fix agent count on policy deploy modal (#209593)](#209593) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:17:47Z","message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix agent count on policy deploy modal","number":209593,"url":"https://github.com/elastic/kibana/pull/209593","mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209593","number":209593,"mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}}]}] BACKPORT--> --------- Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 7, 2025
#210044) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Fix agent count on policy deploy modal (#209593)](#209593) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:17:47Z","message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix agent count on policy deploy modal","number":209593,"url":"https://github.com/elastic/kibana/pull/209593","mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209593","number":209593,"mergeCommit":{"message":"[EDR Workflows] Fix agent count on policy deploy modal (#209593)\n\n## Summary\r\n\r\nFixes the agent count issue on the warning model when saving a Defend\r\npackage policy. Now it uses the same `active` field instead of `all`, as\r\nthe `AgentSummary` component.\r\n\r\nAlso, re-enables flaky unit test for `PolicySettingsLayout`:\r\ncloses: #179984\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"16fae1c86597d2f43e9120578346e26a8b5a88a5"}}]}] BACKPORT--> --------- Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
Contributor
|
This PR didn't make it into the latest BC for v8.16.4 and v8.17.2. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the agent count issue on the warning model when saving a Defend package policy. Now it uses the same
activefield instead ofall, as theAgentSummarycomponent.Also, re-enables flaky unit test for
PolicySettingsLayout:closes: #179984
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.