Skip to content

Remove dependency date-fns !!#209539

Merged
shahzad31 merged 8 commits intoelastic:mainfrom
shahzad31:date-fns
Feb 5, 2025
Merged

Remove dependency date-fns !!#209539
shahzad31 merged 8 commits intoelastic:mainfrom
shahzad31:date-fns

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 4, 2025

Summary

What's better than upgrade? removing it alltogther !!

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Feb 4, 2025
@shahzad31 shahzad31 changed the title Update dependency date-fns to v4 !! Remove dependency date-fns !! Feb 5, 2025
@shahzad31 shahzad31 marked this pull request as ready for review February 5, 2025 14:53
@shahzad31 shahzad31 requested review from a team as code owners February 5, 2025 14:53
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / Search solution tests Search index details page Solution Nav - Search search index details page API key details should show api key

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
investigateApp 667 354 -313

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 480.8KB 234.2KB -246.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
investigateApp 11.0KB 11.0KB -1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
investigateApp 2 0 -2

Total ESLint disabled count

id before after diff
investigateApp 4 2 -2

History

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM. These investigate pages are no longer in use.

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@shahzad31 shahzad31 merged commit 679e2ba into elastic:main Feb 5, 2025
9 checks passed
@shahzad31 shahzad31 deleted the date-fns branch February 5, 2025 16:34
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13162101982

@shahzad31 shahzad31 added the backport:version Backport to applied version labels label Feb 5, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13162118029

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
## Summary

What's better than upgrade? removing it alltogther !!

(cherry picked from commit 679e2ba)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 5, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Remove dependency date-fns !!
(#209539)](#209539)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-02-05T16:34:16Z","message":"Remove
dependency date-fns !! (#209539)\n\n## Summary\r\n\r\nWhat's better than
upgrade? removing it alltogther
!!","sha":"679e2badafcf773024e37b3901bc8c241de41e85","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"Remove
dependency date-fns
!!","number":209539,"url":"https://github.com/elastic/kibana/pull/209539","mergeCommit":{"message":"Remove
dependency date-fns !! (#209539)\n\n## Summary\r\n\r\nWhat's better than
upgrade? removing it alltogther
!!","sha":"679e2badafcf773024e37b3901bc8c241de41e85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209539","number":209539,"mergeCommit":{"message":"Remove
dependency date-fns !! (#209539)\n\n## Summary\r\n\r\nWhat's better than
upgrade? removing it alltogther
!!","sha":"679e2badafcf773024e37b3901bc8c241de41e85"}}]}] BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
## Summary

What's better than upgrade? removing it alltogther !!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants