[UA] Update UI copy for batch reindex API#209403
Merged
TinaHeiligers merged 7 commits intoelastic:mainfrom Feb 4, 2025
Merged
Conversation
TinaHeiligers
added
release_note:skip
jloleysens
reviewed
Feb 4, 2025
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Left a q about also updating the ascii docs! Let me know what you think. I also asked for review from docs team, let's hear what they have to say!
| <FormattedMessage | ||
| id="xpack.upgradeAssistant.esDeprecations.batchReindexingDocsDescription" | ||
| defaultMessage="To start multiple reindexing tasks in a single request, use the Kibana {docsLink}." | ||
| defaultMessage="To start upgrading multiple reindexing tasks in a single request, use the Kibana {docsLink} for indices. The {docsLink} does not support data streams." |
Contributor
There was a problem hiding this comment.
I was thinking, perhaps we should also add some clarification to the docs themselves too?
https://www.elastic.co/guide/en/kibana/current/batch-start-resume-reindex.html
docs/api/upgrade-assistant/batch_reindexing.asciidoc. WDYT?
Contributor
Author
There was a problem hiding this comment.
The asciidoc updates need to be made directly to the pre-9 branches. I'll link back to the original issue for tracking.
Contributor
There was a problem hiding this comment.
It's ok to do them here if this whole PR is going to be backported along with it, for simplicity.
But in any case the docs change will have to be done again for 9.0+ in the new docs system.
Contributor
Author
There was a problem hiding this comment.
WDYT about using something similar to the kib UI copy:
"Start or resume upgrading multiple indices in one request. Additionally, reindexing tasks for upgrading indices that are started or resumed via the batch endpoint will be placed on a queue and executed one-by-one. This ensures that minimal cluster resources are consumed over time. Note: this API does not support data streams."
Contributor
There was a problem hiding this comment.
Sounds good to me 👍
Contributor
Author
There was a problem hiding this comment.
@florent-leborgne the docs update is failing.
Contributor
There was a problem hiding this comment.
The "Comment on PR for .asciidoc changes" check doesn't prevent from merging.
Only the "buildkite/docs-build-pr" is needed to merge docs changes
.../private/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Outdated
Show resolved
Hide resolved
apply suggestion from PR review Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Contributor
Author
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Feb 4, 2025
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback. Approving bc the changes are in the UI, approving to unblock progress.
Contributor
|
It looks like this PR modifies one or more |
Contributor
Author
|
For posterity, updated docs:
|
Contributor
💔 Build Failed
Failed CI StepsHistory
|
Contributor
|
It looks like this PR modifies one or more |
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13142316498 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 4, 2025
fix elastic#209081 Updates UI copy for the batch reindexing API only supporting indices. Note to reviewers: There wasn't an entry for the translation id for French. --------- Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit bdc3470)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 4, 2025
fix elastic#209081 Updates UI copy for the batch reindexing API only supporting indices. Note to reviewers: There wasn't an entry for the translation id for French. --------- Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit bdc3470)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 4, 2025
fix elastic#209081 Updates UI copy for the batch reindexing API only supporting indices. Note to reviewers: There wasn't an entry for the translation id for French. --------- Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit bdc3470)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[UA] Update UI copy for batch reindex API (#209403)](#209403) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-02-04T18:27:55Z","message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Upgrade Assistant","v9.0.0","docs","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[UA] Update UI copy for batch reindex API","number":209403,"url":"https://github.com/elastic/kibana/pull/209403","mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209403","number":209403,"mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[UA] Update UI copy for batch reindex API (#209403)](#209403) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-02-04T18:27:55Z","message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Upgrade Assistant","v9.0.0","docs","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[UA] Update UI copy for batch reindex API","number":209403,"url":"https://github.com/elastic/kibana/pull/209403","mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209403","number":209403,"mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[UA] Update UI copy for batch reindex API (#209403)](#209403) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-02-04T18:27:55Z","message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Upgrade Assistant","v9.0.0","docs","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[UA] Update UI copy for batch reindex API","number":209403,"url":"https://github.com/elastic/kibana/pull/209403","mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209403","number":209403,"mergeCommit":{"message":"[UA] Update UI copy for batch reindex API (#209403)\n\nfix https://github.com/elastic/kibana/issues/209081\r\n\r\nUpdates UI copy for the batch reindexing API only supporting indices.\r\n\r\nNote to reviewers: There wasn't an entry for the translation id for\r\nFrench.\r\n\r\n---------\r\n\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"bdc3470658b53c8d0a20461ed13b5e68015924c5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
fix elastic#209081 Updates UI copy for the batch reindexing API only supporting indices. Note to reviewers: There wasn't an entry for the translation id for French. --------- Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
florent-leborgne
added a commit
to florent-leborgne/kibana
that referenced
this pull request
Mar 31, 2025
florent-leborgne
added a commit
that referenced
this pull request
Apr 1, 2025
This change reproduces the asciidoc change made in #209403 into the new API docs. It'll be picked up the next time the API docs output is generated and refreshed. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 1, 2025
This change reproduces the asciidoc change made in elastic#209403 into the new API docs. It'll be picked up the next time the API docs output is generated and refreshed. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b7d1141)
kibanamachine
added a commit
that referenced
this pull request
Apr 4, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Docs] Reproduce #209403 in new API docs (#216439)](#216439) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"florent-leborgne","email":"florent.leborgne@elastic.co"},"sourceCommit":{"committedDate":"2025-04-01T16:21:43Z","message":"[Docs] Reproduce #209403 in new API docs (#216439)\n\nThis change reproduces the asciidoc change made in\nhttps://github.com//pull/209403 into the new API docs.\nIt'll be picked up the next time the API docs output is generated and\nrefreshed.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b7d1141b6b4e565647c30eac79773d5cf973724e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","APIDocs","backport:version","v9.1.0"],"title":"[Docs] Reproduce #209403 in new API docs","number":216439,"url":"https://github.com/elastic/kibana/pull/216439","mergeCommit":{"message":"[Docs] Reproduce #209403 in new API docs (#216439)\n\nThis change reproduces the asciidoc change made in\nhttps://github.com//pull/209403 into the new API docs.\nIt'll be picked up the next time the API docs output is generated and\nrefreshed.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b7d1141b6b4e565647c30eac79773d5cf973724e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216439","number":216439,"mergeCommit":{"message":"[Docs] Reproduce #209403 in new API docs (#216439)\n\nThis change reproduces the asciidoc change made in\nhttps://github.com//pull/209403 into the new API docs.\nIt'll be picked up the next time the API docs output is generated and\nrefreshed.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b7d1141b6b4e565647c30eac79773d5cf973724e"}}]}] BACKPORT--> Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Lisa Cawley <lcawley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #209081
Updates UI copy for the batch reindexing API only supporting indices.
Note to reviewers: There wasn't an entry for the translation id for French.