[Lens][Datatable] Fix color mapping of transposed datatables#208623
Merged
nickofthyme merged 6 commits intoelastic:mainfrom Feb 5, 2025
Merged
[Lens][Datatable] Fix color mapping of transposed datatables#208623nickofthyme merged 6 commits intoelastic:mainfrom
nickofthyme merged 6 commits intoelastic:mainfrom
Conversation
nickofthyme
added
release_note:fix
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Jan 28, 2025
…lastic#208623 - only handle untransposed data to collate categories - use untransposed data in lens datatable renderer - updates usages of getColorCategories
dej611
approved these changes
Feb 4, 2025
Contributor
dej611
left a comment
dej611
left a comment
There was a problem hiding this comment.
Left a minor performance comment inline.
Tested locally and it solves the issue for the split by scenario.
src/platform/packages/shared/chart-expressions-common/color_categories.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/13151299994 |
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Feb 5, 2025
…#208623) ## Summary In elastic#189895 we added logic to the `getColorCategories` util function to handle transpose columns. This mistakenly assumed the first row of the datatable would include all transposed column ids (i.e. `${value}---${columnId}`). After closer analysis this case is only present the in datatable rendering (i.e. `table_basic.tsx`), but in this context we also have the original non-transposed datatable. So to simplify this we revert this logic to not care about transposed datatables. Now the color mappings are correctly assigned across **split by** columns. <img width="720" alt="image" src="https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38" /> Fixes elastic#208555 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes an issue in Lens (elastic#208555) Table where a split-by metric on a terms rendered incorrect colors in table cells. --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> (cherry picked from commit a93aaee)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…#208623) ## Summary In elastic#189895 we added logic to the `getColorCategories` util function to handle transpose columns. This mistakenly assumed the first row of the datatable would include all transposed column ids (i.e. `${value}---${columnId}`). After closer analysis this case is only present the in datatable rendering (i.e. `table_basic.tsx`), but in this context we also have the original non-transposed datatable. So to simplify this we revert this logic to not care about transposed datatables. Now the color mappings are correctly assigned across **split by** columns. <img width="720" alt="image" src="https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38" /> Fixes elastic#208555 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes an issue in Lens (elastic#208555) Table where a split-by metric on a terms rendered incorrect colors in table cells. --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
nickofthyme
added a commit
that referenced
this pull request
Feb 10, 2025
…208623) (#209927) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Datatable] Fix color mapping of transposed datatables (#208623)](#208623) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T06:07:26Z","message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-major","v9.1.0"],"title":"[Lens][Datatable] Fix color mapping of transposed datatables","number":208623,"url":"https://github.com/elastic/kibana/pull/208623","mergeCommit":{"message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208623","number":208623,"mergeCommit":{"message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58"}}]}] BACKPORT--> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nickofthyme
added a commit
that referenced
this pull request
Feb 10, 2025
…208623) (#209924) # Backport This will backport the following commits from `main` to `9.0`: - [[Lens][Datatable] Fix color mapping of transposed datatables (#208623)](#208623) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T06:07:26Z","message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-major","v9.1.0"],"title":"[Lens][Datatable] Fix color mapping of transposed datatables","number":208623,"url":"https://github.com/elastic/kibana/pull/208623","mergeCommit":{"message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208623","number":208623,"mergeCommit":{"message":"[Lens][Datatable] Fix color mapping of transposed datatables (#208623)\n\n## Summary\r\n\r\nIn #189895 we added logic to the `getColorCategories` util function to\r\nhandle transpose columns. This mistakenly assumed the first row of the\r\ndatatable would include all transposed column ids (i.e.\r\n`${value}---${columnId}`). After closer analysis this case is only\r\npresent the in datatable rendering (i.e. `table_basic.tsx`), but in this\r\ncontext we also have the original non-transposed datatable.\r\n\r\nSo to simplify this we revert this logic to not care about transposed\r\ndatatables. Now the color mappings are correctly assigned across **split\r\nby** columns.\r\n\r\n<img width=\"720\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c588930e-53b9-409f-a257-2c5be35aaa38\"\r\n/>\r\n\r\nFixes #208555\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes an issue in Lens (#208555) Table where a split-by metric on a\r\nterms rendered incorrect colors in table cells.\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>","sha":"a93aaeee97d018c3e20c9cd1e26b8bc596986a58"}}]}] BACKPORT--> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
added
v9.0.0
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #189895 we added logic to the
getColorCategoriesutil function to handle transpose columns. This mistakenly assumed the first row of the datatable would include all transposed column ids (i.e.${value}---${columnId}). After closer analysis the need to handle transpose a datatable is only in the table rendering (i.e.table_basic.tsx), but in this context we also have the original non-transposed datatable.So to simplify this we revert this logic to not care about transposed datatables. Now the color mappings are correctly assigned across split by columns.
Fixes #208555
Checklist
release_note:*label is applied per the guidelinesRelease note
Fixes an issue in Lens (#208555) Table where a split-by metric on a terms rendered incorrect colors in table cells.