Skip to content

[esArchiver/test] use different lengths for random to ensure unique values#20857

Merged
spalger merged 1 commit intoelastic:masterfrom
spalger:fix/flaky-test-20741
Jul 16, 2018
Merged

[esArchiver/test] use different lengths for random to ensure unique values#20857
spalger merged 1 commit intoelastic:masterfrom
spalger:fix/flaky-test-20741

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Jul 16, 2018

fixes #20741

Rather than just generate random words with the default length of 2, generate a random 5 letter word for the type to filter by and 10 letter words for the other types, so there will never be more than 3 records with type1.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 4f867a2 into elastic:master Jul 16, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 16, 2018
…alues (elastic#20857)

fixes elastic#20741

Rather than just generate random words with the default length of 2, generate a random 5 letter word for the type to filter by and 10 letter words for the other types, so there will never be more than 3 records with `type1`.
spalger pushed a commit that referenced this pull request Jul 17, 2018
…alues (#20857) (#20861)

fixes #20741

Rather than just generate random words with the default length of 2, generate a random 5 letter word for the type to filter by and 10 letter words for the other types, so there will never be more than 3 records with `type1`.
@spalger
Copy link
Contributor Author

spalger commented Jul 17, 2018

6.x/6.4: 020d7a3

@spalger spalger deleted the fix/flaky-test-20741 branch July 17, 2018 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test on 6.x: filter_records_stream·js.esArchiver: createFilterRecordsStream() produces record values that have a matching type

2 participants