[Stack Monitoring] New FTR for "view logs" link#208351
Merged
consulthys merged 14 commits intomainfrom Mar 12, 2025
Merged
Conversation
consulthys
added
backport
…View logs" link is present
…ibana into stack-mon-add-ftr-logs
…View logs" link is present
…View logs" link is present
wayneseymour
suggested changes
Mar 10, 2025
Contributor
|
@consulthys Hello there, I'm curious if you've run these from your local against mki? |
Contributor
Author
@wayneseymour I've only run the tests locally like described here |
Contributor
Ok, yeah it looks like it. I mentioned this based on the lack of long timeouts. Here is a doc about it. |
Member
@wayneseymour @consulthys I think there might a misunderstanding here. The tests in this PR are stateful-only, so we don't have to run them against MKI. With that, I'm going to approve this PR from the AppEx QA side. |
pheyos
approved these changes
Mar 12, 2025
Member
pheyos
left a comment
pheyos
left a comment
There was a problem hiding this comment.
x-pack/test/functional/config.base.js changes LGTM
wayneseymour
approved these changes
Mar 12, 2025
Contributor
Sorry about that all, I've got serverless on the brain. Thanks Robert. |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @consulthys |
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13822857939 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
## Summary Closes elastic#202675 A [recent bug](elastic#199902) broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation. This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c218f42)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
## Summary Closes elastic#202675 A [recent bug](elastic#199902) broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation. This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c218f42)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
## Summary Closes elastic#202675 A [recent bug](elastic#199902) broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation. This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c218f42)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
) # Backport This will backport the following commits from `main` to `9.0`: - [[Stack Monitoring] New FTR for "view logs" link (#208351)](#208351) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Valentin Crettaz","email":"valentin.crettaz@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T22:35:28Z","message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Monitoring","release_note:skip","Feature:Stack Monitoring","FTR","v8.18.0","v8.17.2","v9.1.0"],"title":"[Stack Monitoring] New FTR for \"view logs\" link","number":208351,"url":"https://github.com/elastic/kibana/pull/208351","mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208351","number":208351,"mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}}]}] BACKPORT--> Co-authored-by: Valentin Crettaz <valentin.crettaz@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
) # Backport This will backport the following commits from `main` to `8.x`: - [[Stack Monitoring] New FTR for "view logs" link (#208351)](#208351) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Valentin Crettaz","email":"valentin.crettaz@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T22:35:28Z","message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Monitoring","release_note:skip","Feature:Stack Monitoring","FTR","v8.18.0","v8.17.2","v9.1.0"],"title":"[Stack Monitoring] New FTR for \"view logs\" link","number":208351,"url":"https://github.com/elastic/kibana/pull/208351","mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208351","number":208351,"mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}}]}] BACKPORT--> Co-authored-by: Valentin Crettaz <valentin.crettaz@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…4296) # Backport This will backport the following commits from `main` to `8.18`: - [[Stack Monitoring] New FTR for "view logs" link (#208351)](#208351) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Valentin Crettaz","email":"valentin.crettaz@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T22:35:28Z","message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Monitoring","release_note:skip","Feature:Stack Monitoring","FTR","v8.18.0","v8.17.2","v9.1.0"],"title":"[Stack Monitoring] New FTR for \"view logs\" link","number":208351,"url":"https://github.com/elastic/kibana/pull/208351","mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208351","number":208351,"mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](#199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}}]}] BACKPORT--> Co-authored-by: Valentin Crettaz <valentin.crettaz@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary Closes elastic#202675 A [recent bug](elastic#199902) broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation. This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #202675
A recent bug broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation.
This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page.
Checklist