Conversation
💚 Build Succeeded |
|
Hey there @stacey-gammon, just checking in on the progress of this and where it will eventually land. I see it is going in to |
|
Would not be set to go into 6.3, but could perhaps make it into 6.4 depending on review feedback. Is there a reason to push this back into 6.3? Our standard practice is to only back port critical bug fixes. |
|
Good to know about 6.3. Getting the fix in to this version doesn't seem critical to me, but I imagine that 6.4 would be that way we could test regionally (I think that was the original plan) prior to having this configuration be the default in 6.5. |
Yep makes sense. Cloud has the ability to specify kibana.yml defaults though, right? Since that is how we were going to test the default to chromium? So worst case scenario, if this doesn't get in, would you be able to manually set the timeout in kibana.yml, when you default to chromium? |
|
Yes, we should be able to set a default for the timeout in the kibana.yml |
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM. Sad that chromium is so much slower. I hope this improves with subsequent releases.
|
Agreed. If I recall correctly, the chromium team did say they had it on their roadmap to improve performance. Our chromium build is also almost a year old at this point so creating a new one could help. |
Chromium takes a lot longer than Phantom to generate reports. Tests on cloud revealed 30000 was too short. Increasing by 4x, to 120000, since chromium will soon be the default.
The number was chosen pretty arbitrarily, but having it too short can create problems for our users, while having it too long merely delays the time it will take to reveal an error. IMO it's better to be on the safe side and have it too long rather than too short.
Fixes #20832